Update Java APIs with marker throwing runtime TypeDBDriverExceptions, though this is not best practice

Author: flyingsilverfin

java/TypeDB.java

@@ -28,6 +28,7 @@
 import java.util.Set;
 
 import static com.typedb.driver.common.collection.Collections.set;
+import com.typedb.driver.common.exception.TypeDBDriverException;
 
 public class TypeDB {
     public static final String DEFAULT_ADDRESS = "localhost:1729";
@@ -44,7 +45,7 @@ public class TypeDB {
      * @param credentials The credentials to connect with
      * @param driverOptions The connection settings to connect with
      */
-    public static Driver coreDriver(String address, Credentials credentials, DriverOptions driverOptions) {
+    public static Driver coreDriver(String address, Credentials credentials, DriverOptions driverOptions) throws TypeDBDriverException {
         return new DriverImpl(address, credentials, driverOptions);
     }
 
@@ -61,7 +62,7 @@ public static Driver coreDriver(String address, Credentials credentials, DriverO
      * @param credentials The credential to connect with
      * @param driverOptions The connection settings to connect with
      */
-    public static Driver cloudDriver(String address, Credentials credentials, DriverOptions driverOptions) {
+    public static Driver cloudDriver(String address, Credentials credentials, DriverOptions driverOptions) throws TypeDBDriverException {
         return cloudDriver(set(address), credentials, driverOptions);
     }
 
@@ -78,7 +79,7 @@ public static Driver cloudDriver(String address, Credentials credentials, Driver
      * @param credentials The credential to connect with
      * @param driverOptions The connection settings to connect with
      */
-    public static Driver cloudDriver(Set<String> addresses, Credentials credentials, DriverOptions driverOptions) {
+    public static Driver cloudDriver(Set<String> addresses, Credentials credentials, DriverOptions driverOptions) throws TypeDBDriverException {
         return new DriverImpl(addresses, credentials, driverOptions);
     }
 
@@ -96,7 +97,7 @@ public static Driver cloudDriver(Set<String> addresses, Credentials credentials,
      * @param credentials The credential to connect with
      * @param driverOptions The connection settings to connect with
      */
-    public static Driver cloudDriver(Map<String, String> addressTranslation, Credentials credentials, DriverOptions driverOptions) {
+    public static Driver cloudDriver(Map<String, String> addressTranslation, Credentials credentials, DriverOptions driverOptions) throws TypeDBDriverException {
         return new DriverImpl(addressTranslation, credentials, driverOptions);
     }
 }

java/api/Driver.java

@@ -22,6 +22,8 @@
 import com.typedb.driver.api.database.DatabaseManager;
 import com.typedb.driver.api.user.UserManager;
 
+import com.typedb.driver.common.exception.TypeDBDriverException;
+
 import javax.annotation.CheckReturnValue;
 
 public interface Driver extends AutoCloseable {
@@ -56,7 +58,7 @@ public interface Driver extends AutoCloseable {
      * @param type     The type of transaction to be created (READ, WRITE, or SCHEMA)
      */
     @CheckReturnValue
-    Transaction transaction(String database, Transaction.Type type);
+    Transaction transaction(String database, Transaction.Type type) throws TypeDBDriverException ;
 
 //    @CheckReturnValue
 //    Transaction transaction(String database, Transaction.Type type, Options options);

java/api/Transaction.java

@@ -65,7 +65,7 @@ public interface Transaction extends AutoCloseable {
      * @param query The query to execute.
      */
     @CheckReturnValue
-    Promise<? extends QueryAnswer> query(String query);
+    Promise<? extends QueryAnswer> query(String query) throws com.typedb.driver.common.exception.TypeDBDriverException;
 
     /**
      * Registers a callback function which will be executed when this transaction is closed.
@@ -87,7 +87,7 @@ public interface Transaction extends AutoCloseable {
      * transaction.commit()
      * </pre>
      */
-    void commit();
+    void commit()  throws com.typedb.driver.common.exception.TypeDBDriverException;
 
     /**
      * Rolls back the uncommitted changes made via this transaction.
@@ -97,7 +97,7 @@ public interface Transaction extends AutoCloseable {
      * transaction.rollback()
      * </pre>
      */
-    void rollback();
+    void rollback() throws com.typedb.driver.common.exception.TypeDBDriverException;
 
     /**
      * Closes the transaction.
@@ -107,7 +107,7 @@ public interface Transaction extends AutoCloseable {
      * transaction.close()
      * </pre>
      */
-    void close();
+    void close() throws com.typedb.driver.common.exception.TypeDBDriverException;
 
     /**
      * Used to specify the type of transaction.

java/api/database/Database.java

@@ -19,6 +19,8 @@
 
 package com.typedb.driver.api.database;
 
+import com.typedb.driver.common.exception.TypeDBDriverException;
+
 import javax.annotation.CheckReturnValue;
 
 public interface Database {
@@ -38,7 +40,7 @@ public interface Database {
      * </pre>
      */
     @CheckReturnValue
-    String schema();
+    String schema() throws TypeDBDriverException;
 
     /**
      * The types in the schema as a valid TypeQL define query string.
@@ -49,7 +51,7 @@ public interface Database {
      * </pre>
      */
     @CheckReturnValue
-    String typeSchema();
+    String typeSchema() throws TypeDBDriverException;
 
     /**
      * Deletes this database.
@@ -59,7 +61,7 @@ public interface Database {
      * database.delete()
      * </pre>
      */
-    void delete();
+    void delete() throws TypeDBDriverException;
 
 //    /**
 //     * Set of <code>Replica</code> instances for this database.

java/api/database/DatabaseManager.java

@@ -19,6 +19,8 @@
 
 package com.typedb.driver.api.database;
 
+import com.typedb.driver.common.exception.TypeDBDriverException;
+
 import javax.annotation.CheckReturnValue;
 import java.util.List;
 
@@ -38,7 +40,7 @@ public interface DatabaseManager {
      * @param name The name of the database to retrieve
      */
     @CheckReturnValue
-    Database get(String name);
+    Database get(String name) throws TypeDBDriverException;
 
     /**
      * Checks if a database with the given name exists
@@ -51,7 +53,7 @@ public interface DatabaseManager {
      * @param name The database name to be checked
      */
     @CheckReturnValue
-    boolean contains(String name);
+    boolean contains(String name) throws TypeDBDriverException;
 
     /**
      * Create a database with the given name
@@ -64,7 +66,7 @@ public interface DatabaseManager {
      * @param name The name of the database to be created
      */
     // TODO: Return type should be 'Database' but right now that would require 2 server calls in Cloud
-    void create(String name);
+    void create(String name) throws TypeDBDriverException;
 
     /**
      * Retrieves all databases present on the TypeDB server
@@ -75,5 +77,5 @@ public interface DatabaseManager {
      * </pre>
      */
     @CheckReturnValue
-    List<Database> all();
+    List<Database> all() throws TypeDBDriverException;
 }

java/api/user/UserManager.java

@@ -21,6 +21,7 @@
 
 import javax.annotation.CheckReturnValue;
 import java.util.Set;
+import com.typedb.driver.common.exception.TypeDBDriverException;
 
 /**
  * Provides access to all user management methods.
@@ -37,7 +38,7 @@ public interface UserManager {
      * @param username The user name to be checked
      */
     @CheckReturnValue
-    boolean contains(String username);
+    boolean contains(String username) throws TypeDBDriverException;
 
     /**
      * Retrieves a user with the given name.
@@ -50,7 +51,7 @@ public interface UserManager {
      * @param username The name of the user to retrieve
      */
     @CheckReturnValue
-    User get(String username);
+    User get(String username) throws TypeDBDriverException;
 
     // TODO: I don't like this, leaving this way for now. Use driver.users().get(username)
 
@@ -63,7 +64,7 @@ public interface UserManager {
      * </pre>
      */
     @CheckReturnValue
-    User getCurrentUser();
+    User getCurrentUser() throws TypeDBDriverException;
 
     /**
      * Retrieves all users which exist on the TypeDB server.
@@ -73,7 +74,7 @@ public interface UserManager {
      * driver.users().all();
      * </pre>
      */
-    Set<User> all();
+    Set<User> all() throws TypeDBDriverException;
 
     /**
      * Creates a user with the given name &amp; password.
@@ -86,5 +87,5 @@ public interface UserManager {
      * @param username The name of the user to be created
      * @param password The password of the user to be created
      */
-    void create(String username, String password);
+    void create(String username, String password) throws TypeDBDriverException;
 }

java/common/exception/TypeDBException.java

@@ -36,7 +36,7 @@ protected QueryAnswerImpl(com.typedb.driver.jni.QueryAnswer answer) {
         queryType = QueryType.of(query_answer_get_query_type(answer));
     }
 
-    public static QueryAnswerImpl of(com.typedb.driver.jni.QueryAnswer concept) {
+    public static QueryAnswerImpl of(com.typedb.driver.jni.QueryAnswer concept) throws TypeDBDriverException  {
         if (query_answer_is_ok(concept)) return new OkQueryAnswerImpl(concept);
         else if (query_answer_is_concept_row_stream(concept)) return new ConceptRowIteratorImpl(concept);
         else if (query_answer_is_concept_document_stream(concept)) return new ConceptDocumentIteratorImpl(concept);

java/concept/answer/QueryAnswerImpl.java

@@ -41,7 +41,7 @@ public String name() {
     }
 
     @Override
-    public String schema() {
+    public String schema() throws TypeDBDriverException {
         if (!nativeObject.isOwned()) throw new TypeDBDriverException(DATABASE_DELETED);
         try {
             return database_schema(nativeObject);
@@ -51,7 +51,7 @@ public String schema() {
     }
 
     @Override
-    public String typeSchema() {
+    public String typeSchema() throws TypeDBDriverException {
         if (!nativeObject.isOwned()) throw new TypeDBDriverException(DATABASE_DELETED);
         try {
             return database_type_schema(nativeObject);
@@ -61,7 +61,7 @@ public String typeSchema() {
     }
 
     @Override
-    public void delete() {
+    public void delete() throws TypeDBDriverException {
         if (!nativeObject.isOwned()) throw new TypeDBDriverException(DATABASE_DELETED);
         try {
             // NOTE: .released() relinquishes ownership of the native object to the Rust side

java/connection/DatabaseImpl.java

@@ -40,7 +40,7 @@ public DatabaseManagerImpl(com.typedb.driver.jni.TypeDBDriver driver) {
     }
 
     @Override
-    public Database get(String name) throws Error {
+    public Database get(String name) throws TypeDBDriverException {
         try {
             return new DatabaseImpl(databases_get(nativeDriver, name));
         } catch (com.typedb.driver.jni.Error e) {
@@ -49,7 +49,7 @@ public Database get(String name) throws Error {
     }
 
     @Override
-    public boolean contains(String name) throws Error {
+    public boolean contains(String name) throws TypeDBDriverException {
         try {
             return databases_contains(nativeDriver, name);
         } catch (com.typedb.driver.jni.Error e) {
@@ -58,7 +58,7 @@ public boolean contains(String name) throws Error {
     }
 
     @Override
-    public void create(String name) throws Error {
+    public void create(String name) throws TypeDBDriverException {
         try {
             databases_create(nativeDriver, name);
         } catch (com.typedb.driver.jni.Error e) {
@@ -67,7 +67,7 @@ public void create(String name) throws Error {
     }
 
     @Override
-    public List<Database> all() {
+    public List<Database> all()  throws TypeDBDriverException {
         try {
             return new NativeIterator<>(databases_all(nativeDriver)).stream().map(DatabaseImpl::new).collect(toList());
         } catch (com.typedb.driver.jni.Error e) {