Merge for release 2.28.4 (#661)

typedb-bot · web-flow · commit 6cfb17d2561f · 2024-06-14T11:17:16.000+01:00
## Usage and product changes
Merge for release 2.28.4
diff --git a/.bazelrc b/.bazelrc
@@ -33,3 +33,7 @@ build:macos --stamp --workspace_status_command=$PWD/workspace-status.sh
 
 # TODO
 # build:windows --stamp --workspace_status_command=workspace-status.bat
+
+build --@aspect_rules_ts//ts:skipLibCheck=always
+fetch --@aspect_rules_ts//ts:skipLibCheck=always
+query --@aspect_rules_ts//ts:skipLibCheck=always
diff --git a/.circleci/windows/clib/test_assembly.bat b/.circleci/windows/clib/test_assembly.bat
@@ -35,7 +35,7 @@ cmake --build . --config release
 popd
 set PATH=%cd%\test_assembly_clib\typedb-driver-clib-windows-x86_64\lib;%PATH%;
 
-START /B "" typedb-server-windows\typedb server
+START /B "" typedb-server-windows\typedb server --development-mode.enable=true
 powershell -Command "Start-Sleep -Seconds 10"
 
 test_assembly_clib\Release\test_assembly.exe
diff --git a/.circleci/windows/cpp/test_assembly.bat b/.circleci/windows/cpp/test_assembly.bat
@@ -35,7 +35,7 @@ cmake --build . --config release
 popd
 set PATH=%cd%\test_assembly_cpp\typedb-driver-cpp-windows-x86_64\lib;%PATH%;
 
-START /B "" typedb-server-windows\typedb server
+START /B "" typedb-server-windows\typedb server --development-mode.enable=true
 powershell -Command "Start-Sleep -Seconds 10"
 
 test_assembly_cpp\Release\test_assembly.exe
diff --git a/.circleci/windows/csharp/test_deploy_snapshot.bat b/.circleci/windows/csharp/test_deploy_snapshot.bat
@@ -25,7 +25,7 @@ powershell -Command "Move-Item -Path bazel-typedb-driver\external\vaticle_typedb
 7z x typedb-server-windows.zip
 RD /S /Q typedb-server-windows
 powershell -Command "Move-Item -Path typedb-server-windows-* -Destination typedb-server-windows"
-START /B "" typedb-server-windows\typedb server
+START /B "" typedb-server-windows\typedb server --development-mode.enable=true
 
 powershell -Command "(gc csharp\Test\Deployment\NugetApplicationTest.csproj) -replace 'DRIVER_CSHARP_VERSION_MARKER', '0.0.0-%CIRCLE_SHA1%' | Out-File -encoding ASCII csharp\Test\Deployment\NugetApplicationTest.csproj"
 type csharp\Test\Deployment\NugetApplicationTest.csproj
diff --git a/.circleci/windows/java/test_deploy_snapshot.bat b/.circleci/windows/java/test_deploy_snapshot.bat
@@ -25,7 +25,7 @@ powershell -Command "Move-Item -Path bazel-typedb-driver\external\vaticle_typedb
 7z x typedb-server-windows.zip
 RD /S /Q typedb-server-windows
 powershell -Command "Move-Item -Path typedb-server-windows-* -Destination typedb-server-windows"
-START /B "" typedb-server-windows\typedb server
+START /B "" typedb-server-windows\typedb server --development-mode.enable=true
 
 powershell -Command "(gc java\test\deployment\pom.xml) -replace 'DRIVER_JAVA_VERSION_MARKER', '0.0.0-%CIRCLE_SHA1%' | Out-File -encoding ASCII java\test\deployment\pom.xml"
 type java\test\deployment\pom.xml
diff --git a/.circleci/windows/python/test_deploy_snapshot.bat b/.circleci/windows/python/test_deploy_snapshot.bat
@@ -27,7 +27,7 @@ powershell -Command "Move-Item -Path bazel-typedb-driver\external\vaticle_typedb
 7z x typedb-server-windows.zip
 RD /S /Q typedb-server-windows
 powershell -Command "Move-Item -Path typedb-server-windows-* -Destination typedb-server-windows"
-START /B "" typedb-server-windows\typedb server
+START /B "" typedb-server-windows\typedb server --development-mode.enable=true
 
 python3 -m pip install --extra-index-url https://repo.typedb.com/public/public-snapshot/python/simple typedb-driver==0.0.0+%VER%
 cd python/tests/deployment
diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 # TypeDB Drivers
 
 [![Factory](https://factory.vaticle.com/api/status/vaticle/typedb-driver/badge.svg)](https://factory.vaticle.com/vaticle/typedb-driver)
-[![Discord](https://img.shields.io/discord/665254494820368395?color=7389D8&label=chat&logo=discord&logoColor=ffffff)](https://vaticle.com/discord)
+[![Discord](https://img.shields.io/discord/665254494820368395?color=7389D8&label=chat&logo=discord&logoColor=ffffff)](https://typedb.com/discord)
 [![Discussion Forum](https://img.shields.io/discourse/https/forum.typedb.com/topics.svg)](https://forum.typedb.com)
 [![Stack Overflow](https://img.shields.io/badge/stackoverflow-typedb-796de3.svg)](https://stackoverflow.com/questions/tagged/typedb)
 [![Stack Overflow](https://img.shields.io/badge/stackoverflow-typeql-3dce8c.svg)](https://stackoverflow.com/questions/tagged/typeql)
diff --git a/RELEASE_NOTES_LATEST.md b/RELEASE_NOTES_LATEST.md
@@ -9,7 +9,7 @@ Documentation: https://typedb.com/docs/drivers/rust/overview
 
 
 ```sh
-cargo add typedb-driver@2.28.2-rc1
+cargo add typedb-driver@2.28.4
 ```
 
 
@@ -29,7 +29,7 @@ Documentation: https://typedb.com/docs/drivers/java/overview
     <dependency>
         <groupid>com.vaticle.typedb</groupid>
         <artifactid>typedb-driver</artifactid>
-        <version>2.28.2-rc1</version>
+        <version>2.28.4</version>
     </dependency>
 </dependencies>
 ```
@@ -42,7 +42,7 @@ Documentation: https://typedb.com/docs/drivers/python/overview
 Available through https://pypi.org
 
 ```
-pip install typedb-driver==2.28.2-rc1
+pip install typedb-driver==2.28.4
 ```
 
 ### NodeJS driver
@@ -51,7 +51,7 @@ NPM package: https://www.npmjs.com/package/typedb-driver
 Documentation: https://typedb.com/docs/drivers/nodejs/overview
 
 ```
-npm install typedb-driver@2.28.2-rc1
+npm install typedb-driver@2.28.4
 ```
 
 ### C# driver
@@ -61,23 +61,23 @@ Documentation: https://typedb.com/docs/drivers/csharp/overview
 
 ```xml
 <ItemGroup>
-    <PackageReference Include="TypeDB.Driver" Version="2.28.2-rc1" />
-    <PackageReference Include="TypeDB.Driver.Pinvoke.osx-x64" Version="2.28.2-rc1" />
-    <PackageReference Include="TypeDB.Driver.Pinvoke.linux-x64" Version="2.28.2-rc1" />
-    <PackageReference Include="TypeDB.Driver.Pinvoke.win-x64" Version="2.28.2-rc1" />
-    <PackageReference Include="TypeDB.Driver.Pinvoke.osx-arm64" Version="2.28.2-rc1" />
-    <PackageReference Include="TypeDB.Driver.Pinvoke.linux-arm64" Version="2.28.2-rc1" />
+    <PackageReference Include="TypeDB.Driver" Version="2.28.4" />
+    <PackageReference Include="TypeDB.Driver.Pinvoke.osx-x64" Version="2.28.4" />
+    <PackageReference Include="TypeDB.Driver.Pinvoke.linux-x64" Version="2.28.4" />
+    <PackageReference Include="TypeDB.Driver.Pinvoke.win-x64" Version="2.28.4" />
+    <PackageReference Include="TypeDB.Driver.Pinvoke.osx-arm64" Version="2.28.4" />
+    <PackageReference Include="TypeDB.Driver.Pinvoke.linux-arm64" Version="2.28.4" />
 </ItemGroup>
 ```
 
 ### C++ driver
 
-Compiled distributions comprising headers and shared libraries available at: https://cloudsmith.io/~typedb/repos/public-release/packages/?q=name:^typedb-driver-cpp+version:2.28.2-rc1
+Compiled distributions comprising headers and shared libraries available at: https://cloudsmith.io/~typedb/repos/public-release/packages/?q=name:^typedb-driver-cpp+version:2.28.4
 Documentation: https://typedb.com/docs/drivers/cpp/overview
 
 ### C driver
 
-Compiled distributions comprising headers and shared libraries available at: https://cloudsmith.io/~typedb/repos/public-release/packages/?q=name:^typedb-driver-clib+version:2.28.2-rc1
+Compiled distributions comprising headers and shared libraries available at: https://cloudsmith.io/~typedb/repos/public-release/packages/?q=name:^typedb-driver-clib+version:2.28.4
 
 
 ## New Features
@@ -93,6 +93,7 @@ Compiled distributions comprising headers and shared libraries available at: htt
 
 
 ## Other Improvements
-
-
-    
+- **Turn on development mode for tests**
+  We activate the newly introduced in `TypeDB` `--development-mode.enable` flag for all the CI builds of the driver.
+  
+- **Update `nodejs` driver dependencies and fix builds based on the updated `typescript` rules**
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-2.28.2-rc1
+2.28.4
diff --git a/WORKSPACE b/WORKSPACE
@@ -63,12 +63,14 @@ cpp_deps()
 # Load //builder/csharp
 load("@vaticle_dependencies//builder/csharp:deps.bzl", dotnet_deps = "deps")
 dotnet_deps()
+
 load(
     "@rules_dotnet//dotnet:repositories.bzl",
     "dotnet_register_toolchains",
     "rules_dotnet_dependencies",
 )
 rules_dotnet_dependencies()
+
 dotnet_register_toolchains("dotnet", "6.0.413")
 load("@rules_dotnet//dotnet:paket.rules_dotnet_nuget_packages.bzl", "rules_dotnet_nuget_packages")
 rules_dotnet_nuget_packages()
@@ -244,7 +246,6 @@ vaticle_typedb_protocol_npm_repositories()
 
 # Setup rules_ts
 load("@aspect_rules_ts//ts:repositories.bzl", "rules_ts_dependencies")
-
 rules_ts_dependencies(
     ts_version_from = "//nodejs:package.json",
 )
diff --git a/csharp/Test/Behaviour/Connection/ConnectionStepsBase.cs b/csharp/Test/Behaviour/Connection/ConnectionStepsBase.cs
@@ -52,11 +52,6 @@ public abstract class ConnectionStepsBase : Feature, IDisposable
                 {"transaction-timeout-millis", (option, val) => option.TransactionTimeoutMillis(Int32.Parse(val))}
         };
 
-        public static readonly Dictionary<string, string> ServerOptions =
-            new Dictionary<string, string>(){
-                {"--diagnostics.reporting.enable", "false"}
-        };
-
         // TODO: implement configuration and remove skips when @ignore-typedb-driver is removed from .feature.
         protected bool _requiredConfiguration = false;
 
diff --git a/dependencies/maven/artifacts.snapshot b/dependencies/maven/artifacts.snapshot
@@ -18,8 +18,9 @@
 @maven//:com_google_http_client_google_http_client_1_34_2
 @maven//:com_google_j2objc_j2objc_annotations_1_3
 @maven//:com_google_protobuf_protobuf_java_3_21_1
-@maven//:com_vaticle_typedb_typedb_cloud_runner_2_28_0
-@maven//:com_vaticle_typedb_typedb_runner_2_28_0
+@maven//:com_vaticle_typedb_typedb_cloud_runner_2_28_3
+@maven//:com_vaticle_typedb_typedb_common_2_28_1
+@maven//:com_vaticle_typedb_typedb_runner_2_28_3
 @maven//:com_vdurmont_semver4j_3_1_0
 @maven//:commons_codec_commons_codec_1_13
 @maven//:commons_io_commons_io_2_3
diff --git a/dependencies/vaticle/artifacts.bzl b/dependencies/vaticle/artifacts.bzl
@@ -25,7 +25,7 @@ def vaticle_typedb_artifact():
         artifact_name = "typedb-server-{platform}-{version}.{ext}",
         tag_source = deployment["artifact"]["release"]["download"],
         commit_source = deployment["artifact"]["snapshot"]["download"],
-        tag = "2.28.0"
+        tag = "2.28.3"
     )
 
 def vaticle_typedb_cloud_artifact():
@@ -35,10 +35,10 @@ def vaticle_typedb_cloud_artifact():
         artifact_name = "typedb-cloud-server-{platform}-{version}.{ext}",
         tag_source = deployment_private["artifact"]["release"]["download"],
         commit_source = deployment_private["artifact"]["snapshot"]["download"],
-        tag = "2.28.0",
+        tag = "2.28.3",
     )
 
 maven_artifacts = {
-    'com.vaticle.typedb:typedb-runner': '2.28.0',
-    'com.vaticle.typedb:typedb-cloud-runner': '2.28.0',
+    'com.vaticle.typedb:typedb-runner': '2.28.3',
+    'com.vaticle.typedb:typedb-cloud-runner': '2.28.3',
 }
diff --git a/dependencies/vaticle/repositories.bzl b/dependencies/vaticle/repositories.bzl
@@ -21,7 +21,7 @@ def vaticle_dependencies():
     git_repository(
         name = "vaticle_dependencies",
         remote = "https://github.com/vaticle/dependencies",
-        commit = "729d960a92e145e03794395bbe59e02f122f1aee", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
+        commit = "294ef724c3853c9851e1e0c6bc04e0470c724e10", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
     )
 
 def vaticle_typeql():
@@ -36,12 +36,12 @@ def vaticle_typedb_protocol():
         name = "vaticle_typedb_protocol",
         remote = "https://github.com/vaticle/typedb-protocol",
         # NOTE: the sync-marker is also used for workspace status by Bazel!
-        tag = "2.28.0",  # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_typedb_protocol
+        tag = "2.28.4",  # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_typedb_protocol
     )
 
 def vaticle_typedb_behaviour():
     git_repository(
         name = "vaticle_typedb_behaviour",
         remote = "https://github.com/vaticle/typedb-behaviour",
-        commit = "0d5e332128de7d7644cd5403c25ca986f3f2718a",  # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_typedb_behaviour
+        commit = "c196a09fdf0d6af8e09b3f9096b38e455c9e28e2",  # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_typedb_behaviour
     )
diff --git a/java/test/behaviour/connection/ConnectionStepsBase.java b/java/test/behaviour/connection/ConnectionStepsBase.java
@@ -27,6 +27,7 @@
 import com.vaticle.typedb.driver.api.database.Database;
 
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -60,11 +61,7 @@ public abstract class ConnectionStepsBase {
             pair("transaction-timeout-millis", (option, val) -> option.transactionTimeoutMillis(Integer.parseInt(val)))
     );
 
-    public static final Map<String, String> serverOptions = map(
-            pair("--diagnostics.reporting.errors", "false"),
-            pair("--diagnostics.reporting.statistics", "false"),
-            pair("--diagnostics.monitoring.enable", "false")
-    );
+    public static final Map<String, String> serverOptions = Collections.emptyMap();
 
     public static TypeDBTransaction tx() {
         return sessionsToTransactions.get(sessions.get(0)).get(0);
diff --git a/java/test/integration/AddressTranslationTest.java b/java/test/integration/AddressTranslationTest.java
@@ -47,16 +47,11 @@
 public class AddressTranslationTest {
     private static final Logger LOG = LoggerFactory.getLogger(AddressTranslationTest.class);
 
-    private static final Map<String, String> serverOptions = map(
-            pair("--diagnostics.reporting.errors", "false"),
-            pair("--diagnostics.reporting.statistics", "false"),
-            pair("--diagnostics.monitoring.enable", "false")
-    );
     private static final TypeDBCredential credential = new TypeDBCredential("admin", "password", false);
 
     @Test
     public void testAddressTranslation() {
-        TypeDBCloudRunner typedb = TypeDBCloudRunner.create(Paths.get("."), 3, serverOptions);
+        TypeDBCloudRunner typedb = TypeDBCloudRunner.create(Paths.get("."), 3);
         typedb.start();
         Map<String, String> addresses = typedb.externalAddresses().stream().map(address -> pair(address, address))
                 .collect(Collectors.toMap(Pair::first, Pair::second));
diff --git a/java/test/integration/DriverQueryTest.java b/java/test/integration/DriverQueryTest.java
@@ -71,9 +71,7 @@ public class DriverQueryTest {
 
     @BeforeClass
     public static void setUpClass() throws InterruptedException, IOException, TimeoutException {
-        Map<String, String> options = new HashMap<>();
-        options.put("--diagnostics.reporting.errors", "false");
-        typedb = new TypeDBCoreRunner(options);
+        typedb = new TypeDBCoreRunner();
         typedb.start();
         typedbDriver = TypeDB.coreDriver(typedb.address());
         if (typedbDriver.databases().contains("typedb")) typedbDriver.databases().get("typedb").delete();
diff --git a/nodejs/BUILD b/nodejs/BUILD
@@ -82,6 +82,7 @@ ts_project(
         ":node_modules/uuid",
         ":node_modules/@types/uuid",
     ],
+    transpiler = "tsc",
     visibility = ["//visibility:public"],
     out_dir = "dist",
 )
@@ -133,6 +134,7 @@ ts_project(
         ":node_modules/typedoc",
         ":node_modules/@types/node",
     ],
+    transpiler = "tsc",
     visibility = ["//visibility:public"],
     out_dir = ".",
 )
diff --git a/nodejs/test/behaviour/concept/thing/BUILD b/nodejs/test/behaviour/concept/thing/BUILD
@@ -37,6 +37,7 @@ ts_project(
         "//nodejs/test/behaviour/connection:steps-base",
         "//nodejs/test/behaviour/util:util",
     ],
+    transpiler = "tsc",
     declaration = True,
     resolve_json_module = True,
     visibility = ["//visibility:public"],
diff --git a/nodejs/test/behaviour/concept/thing/attribute/BUILD b/nodejs/test/behaviour/concept/thing/attribute/BUILD
@@ -37,6 +37,7 @@ ts_project(
         "//nodejs/test/behaviour/connection:steps-base",
         "//nodejs/test/behaviour/util:util",
     ],
+    transpiler = "tsc",
     resolve_json_module = True,
     visibility = ["//visibility:public"],
 )
diff --git a/nodejs/test/behaviour/concept/thing/entity/BUILD b/nodejs/test/behaviour/concept/thing/entity/BUILD
@@ -37,6 +37,7 @@ ts_project(
         "//nodejs/test/behaviour/connection:steps-base",
         "//nodejs/test/behaviour/util:util",
     ],
+    transpiler = "tsc",
     resolve_json_module = True,
     visibility = ["//visibility:public"],
 )
diff --git a/nodejs/test/behaviour/concept/thing/relation/BUILD b/nodejs/test/behaviour/concept/thing/relation/BUILD
@@ -37,6 +37,7 @@ ts_project(
         "//nodejs/test/behaviour/connection:steps-base",
         "//nodejs/test/behaviour/util:util",
     ],
+    transpiler = "tsc",
     resolve_json_module = True,
     visibility = ["//visibility:public"],
 )
diff --git a/nodejs/test/behaviour/concept/type/attributetype/BUILD b/nodejs/test/behaviour/concept/type/attributetype/BUILD
@@ -36,6 +36,7 @@ ts_project(
         "//nodejs/test/behaviour/connection:steps-base",
         "//nodejs/test/behaviour/util:util",
     ],
+    transpiler = "tsc",
     resolve_json_module = True,
     visibility = ["//visibility:public"],
 )
diff --git a/nodejs/test/behaviour/concept/type/relationtype/BUILD b/nodejs/test/behaviour/concept/type/relationtype/BUILD
@@ -36,6 +36,7 @@ ts_project(
         "//nodejs/test/behaviour/connection:steps-base",
         "//nodejs/test/behaviour/util:util",
     ],
+    transpiler = "tsc",
     resolve_json_module = True,
     visibility = ["//visibility:public"],
 )
diff --git a/nodejs/test/behaviour/concept/type/thingtype/BUILD b/nodejs/test/behaviour/concept/type/thingtype/BUILD
@@ -36,6 +36,7 @@ ts_project(
         "//nodejs/test/behaviour/connection:steps-base",
         "//nodejs/test/behaviour/util:util",
     ],
+    transpiler = "tsc",
     declaration = True,
     resolve_json_module = True,
     visibility = ["//visibility:public"],
diff --git a/nodejs/test/behaviour/config/BUILD b/nodejs/test/behaviour/config/BUILD
@@ -29,6 +29,7 @@ ts_project(
         "//nodejs:node_modules/@types/node",
         "//nodejs:node_modules/@cucumber/cucumber",
     ],
+    transpiler = "tsc",
     resolve_json_module = True,
     visibility = ["//visibility:public"],
 )
diff --git a/nodejs/test/behaviour/connection/BUILD b/nodejs/test/behaviour/connection/BUILD
@@ -34,6 +34,7 @@ ts_project(
         "//nodejs:node_modules/google-protobuf",
         "//nodejs:node_modules/@types/google-protobuf",
     ],
+    transpiler = "tsc",
     resolve_json_module = True,
     visibility = ["//visibility:public"],
 )
@@ -50,6 +51,7 @@ ts_project(
         "//nodejs:node_modules/@cucumber/cucumber",
         "//nodejs/test/behaviour/util:util",
     ],
+    transpiler = "tsc",
     resolve_json_module = True,
     visibility = ["//visibility:public"],
 )
@@ -66,6 +68,7 @@ ts_project(
         "//nodejs:node_modules/@cucumber/cucumber",
         "//nodejs/test/behaviour/util:util",
     ],
+    transpiler = "tsc",
     resolve_json_module = True,
     visibility = ["//visibility:public"],
 )
diff --git a/nodejs/test/behaviour/connection/database/BUILD b/nodejs/test/behaviour/connection/database/BUILD
@@ -35,6 +35,7 @@ ts_project(
         "//nodejs/test/behaviour/util:util",
         "//nodejs/test/behaviour/connection:steps-base",
     ],
+    transpiler = "tsc",
     resolve_json_module = True,
     visibility = ["//visibility:public"],
 )
diff --git a/nodejs/test/behaviour/connection/session/BUILD b/nodejs/test/behaviour/connection/session/BUILD
diff --git a/nodejs/test/behaviour/connection/transaction/BUILD b/nodejs/test/behaviour/connection/transaction/BUILD
diff --git a/nodejs/test/behaviour/connection/user/BUILD b/nodejs/test/behaviour/connection/user/BUILD
diff --git a/nodejs/test/behaviour/query/BUILD b/nodejs/test/behaviour/query/BUILD
diff --git a/nodejs/test/behaviour/util/BUILD b/nodejs/test/behaviour/util/BUILD
diff --git a/nodejs/test/integration/test-cloud-failover.js b/nodejs/test/integration/test-cloud-failover.js
diff --git a/python/tests/integration/cloud_test_rule.bzl b/python/tests/integration/cloud_test_rule.bzl
diff --git a/python/tests/integration/test_cloud_failover.py b/python/tests/integration/test_cloud_failover.py
diff --git a/tool/test/start-cloud-servers.sh b/tool/test/start-cloud-servers.sh
diff --git a/tool/test/start-core-server.sh b/tool/test/start-core-server.sh
