Enable ESLint with our current rule set for .ts files

Author: dfreeman

.eslintignore

@@ -1,2 +1,21 @@
-/blueprints/*/files/**/*.js
-/js
+# unconventional js
+/blueprint-files/
+/test-fixtures/
+/vendor/
+
+# compiled output
+/dist/
+/tmp/
+/js/
+
+# dependencies
+/bower_components/
+/tests/dummy/lib/*/node_modules/
+
+# misc
+/coverage/
+
+# ember-try
+/.node_modules.ember-try/
+/bower.json.ember-try
+/package.json.ember-try

.eslintrc.js

@@ -47,22 +47,33 @@ module.exports = {
 
     // test files
     {
-      files: ['tests/**/*.js'],
-      excludedFiles: ['tests/dummy/**/*.js'],
+      files: ['tests/**/*.{js,ts}'],
+      excludedFiles: ['tests/dummy/**/*.{js,ts}'],
       env: {
         embertest: true,
       },
     },
 
     // node test files
     {
-      files: ['ts/tests/**/*.js'],
+      files: ['ts/tests/**/*.{js,ts}'],
       env: {
         mocha: true,
       },
       rules: {
         'node/no-unpublished-require': 'off',
       },
     },
+
+    // all TypeScript files
+    {
+      files: ['**/*.ts'],
+      parser: 'typescript-eslint-parser',
+      rules: {
+        // These are covered by tsc
+        'no-undef': 'off',
+        'no-unused-var': 'off'
+      }
+    }
   ],
 };

package.json

@@ -24,7 +24,7 @@
   "homepage": "https://github.com/typed-ember/ember-cli-typescript",
   "scripts": {
     "build": "ember build",
-    "lint:js": "eslint ./*.js addon addon-test-support app blueprints config lib server test-support tests",
+    "lint:js": "eslint --ext js,ts .",
     "start": "ember serve",
     "test": "ember test",
     "ci:prepare": "yarn prepublishOnly && rimraf ts",
@@ -94,7 +94,8 @@
     "rimraf": "^2.6.2",
     "testdouble": "^3.5.0",
     "ts-node": "^7.0.1",
-    "typescript": "^2.7.2"
+    "typescript": "^2.7.2",
+    "typescript-eslint-parser": "^15.0.0"
   },
   "resolutions": {
     "@types/ember": "2.8.13"

tests/dummy/app/controllers/application.ts

@@ -1,6 +1,6 @@
-import Ember from 'ember';
+import Controller from '@ember/controller';
 
-export default Ember.Controller.extend({
+export default Controller.extend({
   // Just a very roundabout way of using some ES6 features
   value: ((test = 'Test') => `${test} ${'Value'}`)(),
   foo: 'hello'

tests/dummy/app/helpers/typed-help.ts

@@ -1,4 +1,3 @@
-import Ember from 'ember';
 import { helper } from '@ember/component/helper';
 
 export function typedHelp(/*params, hash*/) {

yarn.lock

@@ -5041,6 +5041,10 @@ lodash.templatesettings@~2.3.0:
     lodash._reinterpolate "~2.3.0"
     lodash.escape "~2.3.0"
 
+[email protected]:
+  version "4.0.1"
+  resolved "https://registry.yarnpkg.com/lodash.unescape/-/lodash.unescape-4.0.1.tgz#bf2249886ce514cda112fae9218cdc065211fc9c"
+
 lodash.uniq@^4.2.0:
   version "4.5.0"
   resolved "https://registry.yarnpkg.com/lodash.uniq/-/lodash.uniq-4.5.0.tgz#d0225373aeb652adc1bc82e4945339a842754773"
@@ -6406,7 +6410,7 @@ sane@^2.2.0, sane@^2.4.1:
   optionalDependencies:
     fsevents "^1.1.1"
 
-"semver@2 || 3 || 4 || 5", semver@^5.1.0, semver@^5.1.1, semver@^5.3.0, semver@^5.4.1, semver@^5.5.0:
+"semver@2 || 3 || 4 || 5", semver@5.5.0, semver@^5.1.0, semver@^5.1.1, semver@^5.3.0, semver@^5.4.1, semver@^5.5.0:
   version "5.5.0"
   resolved "https://registry.yarnpkg.com/semver/-/semver-5.5.0.tgz#dc4bbc7a6ca9d916dee5d43516f0092b58f7b8ab"
 
@@ -7175,6 +7179,13 @@ typedarray@^0.0.6:
   version "0.0.6"
   resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
 
+typescript-eslint-parser@^15.0.0:
+  version "15.0.1"
+  resolved "https://registry.yarnpkg.com/typescript-eslint-parser/-/typescript-eslint-parser-15.0.1.tgz#fb18bfd255821c5c1dcb98be826f7e4fac63480c"
+  dependencies:
+    lodash.unescape "4.0.1"
+    semver "5.5.0"
+
 typescript@^2.7.2:
   version "2.8.1"
   resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.8.1.tgz#6160e4f8f195d5ba81d4876f9c0cc1fbc0820624"