Skip to content

Commit 1a28a0f

Browse files
authored
Merge pull request #138 from jamescdavis/add-types-to-includes
Add types to include in tsconfig.json
2 parents d140a7a + 7cb3654 commit 1a28a0f

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

blueprints/ember-cli-typescript/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ module.exports = {
3131
let inRepoAddons = (this.project.pkg['ember-addon'] || {}).paths || [];
3232
let hasMirage = 'ember-cli-mirage' in (this.project.pkg.devDependencies || {});
3333
let isAddon = this.project.isEmberCLIAddon();
34-
let includes = ['app', isAddon && 'addon', 'tests'].concat(inRepoAddons).filter(Boolean);
34+
let includes = ['app', isAddon && 'addon', 'tests', 'types'].concat(inRepoAddons).filter(Boolean);
3535

3636
// Mirage is already covered for addons because it's under `tests/`
3737
if (hasMirage && !isAddon) {

node-tests/blueprints/ember-cli-typescript-test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ describe('Acceptance: ember-cli-typescript generator', function() {
4040
expect(tsconfigJson.compilerOptions.inlineSourceMap).to.equal(true);
4141
expect(tsconfigJson.compilerOptions.inlineSources).to.equal(true);
4242

43-
expect(tsconfigJson.include).to.deep.equal(['app', 'tests']);
43+
expect(tsconfigJson.include).to.deep.equal(['app', 'tests', 'types']);
4444

4545
const projectTypes = file('types/my-app/index.d.ts');
4646
expect(projectTypes).to.exist;
@@ -77,7 +77,7 @@ describe('Acceptance: ember-cli-typescript generator', function() {
7777
'*': ['types/*'],
7878
});
7979

80-
expect(tsconfigJson.include).to.deep.equal(['app', 'addon', 'tests']);
80+
expect(tsconfigJson.include).to.deep.equal(['app', 'addon', 'tests', 'types']);
8181

8282
const projectTypes = file('types/dummy/index.d.ts');
8383
expect(projectTypes).to.exist;
@@ -114,7 +114,7 @@ describe('Acceptance: ember-cli-typescript generator', function() {
114114
'*': ['types/*'],
115115
});
116116

117-
expect(json.include).to.deep.equal(['app', 'tests', 'lib/my-addon-1', 'lib/my-addon-2']);
117+
expect(json.include).to.deep.equal(['app', 'tests', 'types', 'lib/my-addon-1', 'lib/my-addon-2']);
118118

119119
const projectTypes = file('types/my-app/index.d.ts');
120120
expect(projectTypes).to.exist;
@@ -146,7 +146,7 @@ describe('Acceptance: ember-cli-typescript generator', function() {
146146
'*': ['types/*'],
147147
});
148148

149-
expect(json.include).to.deep.equal(['app', 'tests', 'mirage']);
149+
expect(json.include).to.deep.equal(['app', 'tests', 'types', 'mirage']);
150150
});
151151
});
152152

@@ -176,7 +176,7 @@ describe('Acceptance: ember-cli-typescript generator', function() {
176176
'*': ['types/*'],
177177
});
178178

179-
expect(json.include).to.deep.equal(['app', 'addon', 'tests']);
179+
expect(json.include).to.deep.equal(['app', 'addon', 'tests', 'types']);
180180
});
181181
});
182182
});

0 commit comments

Comments
 (0)