Skip to content

Commit 63499fe

Browse files
committed
Add more info after the release.
1 parent b9a3e17 commit 63499fe

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

.github/workflows/github-deploy.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@ on:
33
push:
44
branches:
55
- trunk
6-
# To simplify the release process, the publishing is triggred on any push tag.
6+
# To simplify the release process, the publishing is triggered on tag.
77
# We should make sure to only push tags for new releases.
88
# If we start using tags for non-release purposes,
99
# this needs to be updated.
10+
#
11+
# We need to explicitly configure an expression that matches anything.
1012
tags: [ "**" ]
1113
pull_request:
1214

RELEASE.rst

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,20 @@ To do a release, follow these steps:
1010
* Update the `Changelog.rst` file with the summary of the changes.
1111
* Commit the changes to GitHub and create a PR
1212
* Request the review from `twisted-contributors` team.
13-
* Once the PR is approved create a `git tag` based on the latest commit from
14-
the PR.
15-
The tag name should be the current version.
16-
* Push the tag to Github.
17-
This will automatically trigger the build process for the wheels and will
18-
publish them to PyPI
13+
* Once the PR is approved, create a new release via `GitHub Releases<https://github.com/twisted/twisted-iocpsupport/releases/new>`_.
14+
The tag name should be the current version. Select to create a new tag.
15+
Select the release branch as the target branch.
16+
Copy/paste the release notes.
17+
* Publish the release.
18+
This will automatically trigger that creation of a new that,
19+
which in turn will trigger the build process for the wheels and will
20+
publish them to PyPI.
21+
22+
Using GitHub Releases is not required.
23+
You can also just create and push a new tag.
24+
It will still trigger the publish process.
25+
26+
GitHub Release should just make it a bit easier to detect the release of this project.
1927

2028

2129
Implementation details

0 commit comments

Comments
 (0)