Skip to content

Changing the 'OUTPUT FORMAT' won't reflect on the 'OUTPUT FORMAT' column in Generated Datasets section #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdgun opened this issue Apr 30, 2018 · 4 comments
Labels
Bug Something isn't working Task

Comments

@sdgun
Copy link
Collaborator

sdgun commented Apr 30, 2018

Target URL

http://127.0.0.1:5000/dashboard

Steps to Reproduce

  1. Open the URL http://127.0.0.1:5000/
  2. Click 'Generate Dataset' from one of the items from Dashboard [Configurations]
  3. Now from the 'Generated Datasets' list select one item > Edit Config
  4. Go to the last screen and change the OUTPUT FORMAT (FHIR-XML > FHIR-JSON)
  5. Click SAVE
  6. In the dashboard check the column 'OUTPUT FORMAT'

Actual Result(s)

  • Changing the 'OUTPUT FORMAT' won't reflect on the 'OUTPUT FORMAT' column in Generated Datasets section

Expected Result(s)

  • Must display the new format on the list

Frequency

  • 5/5

Environment Details

  • Device(s): Laptop
  • Resolution: 1366 x 768
  • Operating System: Windows 7 64bit
  • Browser(s): Chrome 66.0.3359.117 (Official Build) (64-bit)

Image(s)/Video(s)/Console Log/Crash Log

https://www.screencast.com/t/y9qvrdFtGRtd

@sdgun sdgun added the Bug Something isn't working label Apr 30, 2018
@jiangliwu
Copy link

@sdgun you misunderstood this, Generated Dataset will never updated again when dataset generated from Configurations, you need reGenerate Dataset when configuration updated.

@dustinWeaver
Copy link

@jiangliwu, what would it take to make the generation asynchronous? In other words, when a user clicks "generate dataset", the modal closes and we have a "generating" status. We'd need to add the "status" column to the table as well. Could make the values "complete", "generating".

cc: @ksmacleod99

@jiangliwu
Copy link

@dustinWeaver
a. for asynchronous mode, i think this is no problem, but this feature need more time, and are you answering for this issue #50?
b. for this issue, Generated Dataset format type will not changed if generate completed.

@dustinWeaver
Copy link

@jiangliwu, you're correct. Not sure how my comment got posted here.

Please let us know on Slack your estimated cost to make this change.

Cc: @ksmacleod99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Task
Projects
None yet
Development

No branches or pull requests

4 participants