Skip to content

Commit da40f4c

Browse files
committed
[Plot] Add current conductor bounds to telemetry requests via the old API. Replaces telemetry decorator. Fixes nasa#1458
1 parent 6fa5a31 commit da40f4c

File tree

4 files changed

+26
-104
lines changed

4 files changed

+26
-104
lines changed

platform/features/conductor/compatibility/bundle.js

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,9 @@
2121
*****************************************************************************/
2222

2323
define([
24-
"./src/ConductorTelemetryDecorator",
2524
"./src/ConductorRepresenter",
2625
'legacyRegistry'
2726
], function (
28-
ConductorTelemetryDecorator,
2927
ConductorRepresenter,
3028
legacyRegistry
3129
) {
@@ -39,16 +37,6 @@ define([
3937
"openmct"
4038
]
4139
}
42-
],
43-
"components": [
44-
{
45-
"type": "decorator",
46-
"provides": "telemetryService",
47-
"implementation": ConductorTelemetryDecorator,
48-
"depends": [
49-
"openmct"
50-
]
51-
}
5240
]
5341
}
5442
});

platform/features/conductor/compatibility/src/ConductorTelemetryDecorator.js

Lines changed: 0 additions & 87 deletions
This file was deleted.

platform/telemetry/src/TelemetryCapability.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,8 @@ define(
139139
type = domainObject.getCapability("type"),
140140
typeRequest = (type && type.getDefinition().telemetry) || {},
141141
modelTelemetry = domainObject.getModel().telemetry,
142-
fullRequest = Object.create(typeRequest);
142+
fullRequest = Object.create(typeRequest),
143+
bounds;
143144

144145
// Add properties from the telemetry field of this
145146
// specific domain object.
@@ -160,6 +161,12 @@ define(
160161
fullRequest.key = domainObject.getId();
161162
}
162163

164+
if (request.start === undefined && request.end === undefined) {
165+
bounds = this.openmct.conductor.bounds();
166+
fullRequest.start = bounds.start;
167+
fullRequest.end = bounds.end;
168+
}
169+
163170
return fullRequest;
164171
};
165172

platform/telemetry/test/TelemetryCapabilitySpec.js

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,15 @@ define(
9797
});
9898

9999
mockAPI = {
100-
telemetry: mockTelemetryAPI
100+
telemetry: mockTelemetryAPI,
101+
conductor: {
102+
bounds: function () {
103+
return {
104+
start: 0,
105+
end: 1
106+
};
107+
}
108+
}
101109
};
102110

103111
telemetry = new TelemetryCapability(
@@ -150,7 +158,9 @@ define(
150158
expect(telemetry.getMetadata()).toEqual({
151159
id: "testId", // from domain object
152160
source: "testSource",
153-
key: "testKey"
161+
key: "testKey",
162+
start: 0,
163+
end: 1
154164
});
155165
});
156166

@@ -164,7 +174,9 @@ define(
164174
expect(telemetry.getMetadata()).toEqual({
165175
id: "testId", // from domain object
166176
source: "testSource", // from model
167-
key: "testId" // from domain object
177+
key: "testId", // from domain object
178+
start: 0,
179+
end: 1
168180
});
169181
});
170182

@@ -243,7 +255,9 @@ define(
243255
[{
244256
id: "testId", // from domain object
245257
source: "testSource",
246-
key: "testKey"
258+
key: "testKey",
259+
start: 0,
260+
end: 1
247261
}]
248262
);
249263

0 commit comments

Comments
 (0)