Possible Solve For System Navigation

[keeleycarrigan]

I'm not well versed in Android phone usage, much less Android development but it seems like I might have found something to allow the OS to apply the proper bottom padding to the view. Would be great if this works out because I'd much rather use your tabs than a drawer for navigation.

https://medium.com/google-developers/why-would-i-want-to-fitssystemwindows-4e26d9ce1eec

TLDR - seems like android:fitsSystemWindows=“true” might work.

[timomeh]

Hmmm. android:fitsSystemWindows="true" could work if there were an Android Layout for the Bottom Navigation. Since it's an only-JS Component, there really is no Android Layout here.

I could write a Bridge for this, but then I would much rather write a standalone module which applies fitsSystemWindows on a child view (some kind of Higher Order Component).

Then again, fitsSystemWindows could simply be a prop (or a style) for View in React Native itself.

I think the solution with a Bridge in a separate module would be nice. Right now I don't have time for this. Maybe someone wants to grab this and make it?

[keeleycarrigan]

Yea I was looking at the attribute wrong. When I first saw it I was just thinking it was an attribute you could put in AndroidManifest.xml

[keeleycarrigan]

Actually, would this module work? https://www.npmjs.com/package/react-native-detect-navbar-android

[timomeh]

This looks very promising! If you have time for this, would you mind testing it and maybe sharing some code, if it works? Thank you!

[keeleycarrigan]

Yes! I will check it out. I'm super excited because I've been searching for a way to use your module for a couple days now, haha.

[timomeh]

Of course you could use it without the behind-the-nav-bar-thingy, but of course it looks waaay better this way!

[keeleycarrigan]

That package is working in my simulator but I need to make a pull request to the author to update the documentation because it's off a little and I had to investigate a bunch to see why it wasn't working initially. But I think this is a real solve!

[keeleycarrigan]

Only issue I'm seeing with the attributes to make the bar transparent is the header for a Stack Navigator goes behind the status bar.

This can be fixed by added padding and height to a header. Styles could be perfected though.

navigationOptions: ({navigation}) => ({
        headerStyle: {
          paddingTop: 30,
          height: 60 + 30,
        }
    })

[timomeh]

Looks very promising! Thank you very much. So I think that could be the solution. Can you maybe share some code for the innerStyles of the BottomNavigation working together with this detection module? This way anybody who's interested in doing this has a solution right away.

[keeleycarrigan]

Still working on an example implementation. I have a couple ideas now but because the soft keyboard check is a promise it is returning after I need it in the simple example project I've got. I'm also still wrapping my head around React Navigation so I'm trying to figure out the best place to put this logic to apply the bottom padding.

[keeleycarrigan]

Here's a basic example. I had to wrap the main tab navigator in a component because DetectNavbar returns a promise and most times the promise doesn't return until the component is rendered. If you don't use React Navigation it would be pretty similar to this, but this was the only way I could get the TabNavigator to re-render when the promise returns. You also need to add padding to the top of any StackNavigator headers when setting the Android bars to transparent. I'm open to any suggestions on how to make this better.

class StacksInTabs extends Component {
    constructor (props) {
        super(props);
        
        this.state = { softKeys: false }
    }
    
    componentDidMount () {
        if (Platform.OS === 'android') {
            DetectNavbar.hasSoftKeys().then((softKeys) => {
              this.setState({ softKeys });
            });
        }
    }
    
    render () {
        let tabBarConfig = {
          tabBarPosition: 'bottom',
          animationEnabled: false,
          swipeEnabled: false
      };
      
      if (Platform.OS === 'android') {
          tabBarConfig.tabBarComponent = NavigationComponent;
          tabBarConfig.tabBarOptions = {
              bottomNavigationOptions: {
                  style: {
                      height: this.state.softKeys ? 104 : 56
                  },
                  innerStyle: {
                      paddingBottom: this.state.softKeys ? 48 : 0
                  },
                  
              }
          }
      }
        const Tabs = TabNavigator({
          MainTab: {
            screen: MainTab,
            path: '/',
            navigationOptions: {
              tabBarLabel: 'Home',
              tabBarIcon: ({ tintColor, focused }) => (
                <Ionicons
                  name={focused ? 'ios-home' : 'ios-home-outline'}
                  size={26}
                  style={{ color: tintColor }}
                />
              ),
            },
          },
          SettingsTab: {
            screen: SettingsTab,
            path: '/settings',
            navigationOptions: {
              tabBarLabel: 'Settings',
              tabBarIcon: ({ tintColor, focused }) => (
                <Ionicons
                  name={focused ? 'ios-settings' : 'ios-settings-outline'}
                  size={26}
                  style={{ color: tintColor }}
                />
              ),
            },
          },
      }, tabBarConfig);

        return <Tabs />
    }
}

[timomeh]

@keeleycarrigan Thank you! I will try this out in the next days and if it works I'll update the README.

[keeleycarrigan]

Here's the full file. It's adapted from one of Facebook's examples. Styling is good. I think it's something with React Navigation but having inner tabs doesn't work great on Android. Works great on iOS. But if you don't have inner tabs everything is probably good. Let me know if I can improve the example or anything!

Facebook's SampleText component.

import React, { Component } from 'react';
import {
  Button,
  Platform,
  ScrollView,
  StatusBar
} from 'react-native';
import {
  StackNavigator,
  TabNavigator,
} from 'react-navigation';
import { NavigationComponent } from 'react-native-material-bottom-navigation';
import { DetectNavbar } from 'react-native-detect-navbar-android';

import Ionicons from 'react-native-vector-icons/Ionicons';
import SampleText from './sample-txt';

const MyNavScreen = ({ navigation, banner }) => (
  <ScrollView>
    <SampleText>{banner}</SampleText>
    <Button
      onPress={() => navigation.navigate('Profile', { name: 'Jordan' })}
      title="Go to a profile screen"
    />
    <Button
      onPress={() => navigation.navigate('NotifSettings')}
      title="Go to notification settings"
    />
    <Button
      onPress={() => navigation.navigate('SettingsTab')}
      title="Go to settings"
    />
    <Button
      onPress={() => navigation.goBack(null)}
      title="Go back"
    />
  </ScrollView>
);

const MyHomeScreen = ({ navigation }) => (
  <MyNavScreen
    banner="Home Screen"
    navigation={navigation}
  />
);

const MyHomeScreen2 = ({ navigation }) => (
  <MyNavScreen
    banner="Home Screen"
    navigation={navigation}
  />
);

const MyProfileScreen = ({ navigation }) => (
  <MyNavScreen
    banner={`${navigation.state.params.name}s Profile`}
    navigation={navigation}
  />
);
MyProfileScreen.navigationOptions = ({ navigation }) => ({
  title: `${navigation.state.params.name}'s Profile!`,
});

const MyNotificationsSettingsScreen = ({ navigation }) => (
  <MyNavScreen
    banner="Notification Settings"
    navigation={navigation}
  />
);

const MySettingsScreen = ({ navigation }) => (
  <MyNavScreen
    banner="Settings"
    navigation={navigation}
  />
);

const stackConfig = {};

if (Platform.OS === 'android') {
    stackConfig = {
        navigationOptions: {
            headerStyle: {
              paddingTop: StatusBar.currentHeight,
              height: 56 + StatusBar.currentHeight,
              elevation: 0
            }
        }
    };
}

const HomeTabs = {
    HomeTabOne: {
        screen: MyHomeScreen,
    },
    HomeTabTwo: {
        screen: MyHomeScreen2,
    }
};

const mainTabConfig = {
    ...TabNavigator.Presets.AndroidTopTabs,
    animationEnabled: false,
    swipeEnabled: true,
}

const MainTab = StackNavigator({
  Home: {
    screen: TabNavigator(HomeTabs, mainTabConfig),
    path: '/',
    navigationOptions: {
      title: 'Welcome',
    //   headerMode: 'none'
    },
  },
  Profile: {
    screen: MyProfileScreen,
    path: '/people/:name',
    navigationOptions: ({ navigation }) => ({
      title: `${navigation.state.params.name}'s Profile!`,
    }),
  },
}, stackConfig);

const SettingsTab = StackNavigator({
  Settings: {
    screen: MySettingsScreen,
    path: '/',
    navigationOptions: () => ({
      title: 'Settings',
    }),
  },
  NotifSettings: {
    screen: MyNotificationsSettingsScreen,
    navigationOptions: {
      title: 'Notification Settings',
    },
  },
}, stackConfig);


class StacksInTabs extends Component {
    constructor (props) {
        super(props);
        
        this.state = { softKeys: false }
    }
    
    componentDidMount () {
        if (Platform.OS === 'android') {
            DetectNavbar.hasSoftKeys().then((softKeys) => {
              this.setState({ softKeys });
            });
        }
    }
    
    render () {
        let tabBarConfig = {
          tabBarPosition: 'bottom',
          animationEnabled: false,
          swipeEnabled: false
      };
      
      if (Platform.OS === 'android') {
          tabBarConfig.tabBarComponent = NavigationComponent;
          tabBarConfig.tabBarOptions = {
              bottomNavigationOptions: {
                  style: {
                      height: this.state.softKeys ? 104 : 56
                  },
                  innerStyle: {
                      paddingBottom: this.state.softKeys ? 48 : 0
                  },
                  
              }
          }
      }
        const Tabs = TabNavigator({
          MainTab: {
            screen: MainTab,
            path: '/',
            navigationOptions: {
              tabBarLabel: 'Home',
              tabBarIcon: ({ tintColor, focused }) => (
                <Ionicons
                  name={focused ? 'ios-home' : 'ios-home-outline'}
                  size={26}
                  style={{ color: tintColor }}
                />
              ),
            },
          },
          SettingsTab: {
            screen: SettingsTab,
            path: '/settings',
            navigationOptions: {
              tabBarLabel: 'Settings',
              tabBarIcon: ({ tintColor, focused }) => (
                <Ionicons
                  name={focused ? 'ios-settings' : 'ios-settings-outline'}
                  size={26}
                  style={{ color: tintColor }}
                />
              ),
            },
          },
      }, tabBarConfig);

        return <Tabs />
    }
}

export default StacksInTabs;