Merge pull request desktop#17519 from desktop/alertdialog-for-local-changes-error

Use `role=alertdialog` for errors when trying to do operations with local changes

Author: sergiou87

app/src/ui/local-changes-overwritten/local-changes-overwritten-dialog.tsx

@@ -62,14 +62,18 @@ export class LocalChangesOverwrittenDialog extends React.Component<
         onDismissed={this.props.onDismissed}
         onSubmit={this.onSubmit}
         type="error"
+        role="alertdialog"
+        ariaDescribedBy="local-changes-error-description"
       >
         <DialogContent>
-          <p>
-            Unable to {this.getRetryActionName()} when changes are present on
-            your branch.{overwrittenText}
-          </p>
-          {this.renderFiles()}
-          {this.renderStashText()}
+          <div id="local-changes-error-description">
+            <p>
+              Unable to {this.getRetryActionName()} when changes are present on
+              your branch.{overwrittenText}
+            </p>
+            {this.renderFiles()}
+            {this.renderStashText()}
+          </div>
         </DialogContent>
         {this.renderFooter()}
       </Dialog>