Skip to content

Commit 747cae0

Browse files
refactor to add make_date_range_filter
1 parent 62c66b8 commit 747cae0

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

things/database.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -627,7 +627,7 @@ def make_filter(column, value):
627627

628628
def make_date_filter(date_column: str, offset) -> str:
629629
"""
630-
Return a SQL filter to limit the date range of the SQL query.
630+
Return a SQL filter to limit the date (range) of the SQL query.
631631
632632
Parameters
633633
----------
@@ -661,11 +661,24 @@ def make_date_filter(date_column: str, offset) -> str:
661661
# Offset not specified
662662
if offset is None:
663663
return ""
664+
664665
# Offset is bool
665666
if isinstance(offset, bool):
666667
return make_filter(date_column, offset)
667668

669+
# Offset needs to be processed
670+
return make_date_range_filter(date_column, offset)
671+
672+
673+
def make_date_range_filter(date_column: str, offset: str) -> str:
674+
"""
675+
Return a SQL filter to limit the date range of the SQL query.
676+
677+
See `make_date_filter` for details.
678+
"""
668679
operator = ">"
680+
modifier = ""
681+
669682
# Offset is in the future
670683
if offset == "future":
671684
offset = "0d"

0 commit comments

Comments
 (0)