Skip to content

Commit d9140d6

Browse files
committed
reducing verbosity on query creation, that part is not so important/
Signed-off-by: Pedro Tanaka <[email protected]>
1 parent 7a180a6 commit d9140d6

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

engine/engine.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -281,24 +281,18 @@ func (e *Engine) MakeInstantQuery(ctx context.Context, q storage.Queryable, opts
281281
DisableDuplicateLabelCheck: e.disableDuplicateLabelChecks,
282282
}
283283

284-
optimizeSpan := tracing.ChildSpan(span, "optimize_plan")
285284
lplan, warns := logicalplan.NewFromAST(expr, qOpts, planOpts).Optimize(e.getLogicalOptimizers(opts))
286-
optimizeSpan.Finish()
287285

288286
ctx = warnings.NewContext(ctx)
289287
defer func() { warns.Merge(warnings.FromContext(ctx)) }()
290288

291-
scannersSpan := tracing.ChildSpan(span, "create_storage_scanners")
292289
scanners, err := e.storageScanners(q, qOpts, lplan)
293-
scannersSpan.Finish()
294290
if err != nil {
295291
tracing.LogError(span, err)
296292
return nil, errors.Wrap(err, "creating storage scanners")
297293
}
298294

299-
execSpan := tracing.ChildSpan(span, "create_execution")
300295
exec, err := execution.New(ctx, lplan.Root(), scanners, qOpts)
301-
execSpan.Finish()
302296
if err != nil {
303297
tracing.LogError(span, err)
304298
return nil, err
@@ -402,24 +396,18 @@ func (e *Engine) MakeRangeQuery(ctx context.Context, q storage.Queryable, opts *
402396
DisableDuplicateLabelCheck: e.disableDuplicateLabelChecks,
403397
}
404398

405-
optimizeSpan := tracing.ChildSpan(span, "optimize_plan")
406399
lplan, warns := logicalplan.NewFromAST(expr, qOpts, planOpts).Optimize(e.getLogicalOptimizers(opts))
407-
optimizeSpan.Finish()
408400

409401
ctx = warnings.NewContext(ctx)
410402
defer func() { warns.Merge(warnings.FromContext(ctx)) }()
411403

412-
scannersSpan := tracing.ChildSpan(span, "create_storage_scanners")
413404
scnrs, err := e.storageScanners(q, qOpts, lplan)
414-
scannersSpan.Finish()
415405
if err != nil {
416406
tracing.LogError(span, err)
417407
return nil, errors.Wrap(err, "creating storage scanners")
418408
}
419409

420-
execSpan := tracing.ChildSpan(span, "create_execution")
421410
exec, err := execution.New(ctx, lplan.Root(), scnrs, qOpts)
422-
execSpan.Finish()
423411
if err != nil {
424412
tracing.LogError(span, err)
425413
return nil, err

0 commit comments

Comments
 (0)