fix lint

Signed-off-by: yeya24 <[email protected]>

Author: yeya24

engine/pushdown_test.go

@@ -2,14 +2,17 @@ package engine_test
 
 import (
 	"context"
-	"errors"
 	"fmt"
 	"math/rand"
 	"strconv"
 	"testing"
 	"time"
 
+	"github.com/thanos-io/promql-engine/engine"
+	"github.com/thanos-io/promql-engine/logicalplan"
+
 	"github.com/cortexproject/promqlsmith"
+	"github.com/efficientgo/core/errors"
 	"github.com/efficientgo/core/testutil"
 	"github.com/google/go-cmp/cmp"
 	"github.com/prometheus/prometheus/model/labels"
@@ -19,8 +22,6 @@ import (
 	"github.com/prometheus/prometheus/storage"
 	"github.com/prometheus/prometheus/tsdb/chunkenc"
 	"github.com/prometheus/prometheus/util/annotations"
-	"github.com/thanos-io/promql-engine/engine"
-	"github.com/thanos-io/promql-engine/logicalplan"
 )
 
 type projectionQuerier struct {
@@ -88,7 +89,7 @@ func (m projectionSeriesSet) At() storage.Series {
 	}
 }
 
-// projectedSeries wraps a storage.Series but returns projected labels
+// projectedSeries wraps a storage.Series but returns projected labels.
 type projectedSeries struct {
 	storage.Series
 	lset labels.Labels
@@ -105,7 +106,7 @@ func (s *projectedSeries) Iterator(iter chunkenc.Iterator) chunkenc.Iterator {
 func (m projectionSeriesSet) Err() error                        { return m.SeriesSet.Err() }
 func (m projectionSeriesSet) Warnings() annotations.Annotations { return m.SeriesSet.Warnings() }
 
-// Implement the Querier interface methods
+// Implement the Querier interface methods.
 func (m *projectionQuerier) Select(ctx context.Context, sortSeries bool, hints *storage.SelectHints, matchers ...*labels.Matcher) storage.SeriesSet {
 	return projectionSeriesSet{
 		SeriesSet: m.Querier.Select(ctx, sortSeries, hints, matchers...),
@@ -120,7 +121,7 @@ func (m *projectionQuerier) LabelNames(ctx context.Context, _ *storage.LabelHint
 }
 func (m *projectionQuerier) Close() error { return nil }
 
-// projectionQueryable is a storage.Queryable that applies projection to the querier
+// projectionQueryable is a storage.Queryable that applies projection to the querier.
 type projectionQueryable struct {
 	storage.Queryable
 }
@@ -256,7 +257,7 @@ func TestProjectionPushdownWithFuzz(t *testing.T) {
 	}
 }
 
-// containsAggregationOrBinaryOperation checks if the expression contains any aggregation or binary operations
+// containsAggregationOrBinaryOperation checks if the expression contains any aggregation or binary operations.
 func containsAggregationOrBinaryOperation(expr parser.Expr) bool {
 	found := false
 	parser.Inspect(expr, func(node parser.Node, _ []parser.Node) error {

logicalplan/projection_pushdown.go

@@ -1,9 +1,10 @@
 package logicalplan
 
 import (
+	"github.com/thanos-io/promql-engine/query"
+
 	"github.com/prometheus/prometheus/promql/parser"
 	"github.com/prometheus/prometheus/util/annotations"
-	"github.com/thanos-io/promql-engine/query"
 )
 
 type ProjectionPushdown struct {
@@ -15,9 +16,7 @@ func (p ProjectionPushdown) Optimize(plan Node, _ *query.Options) (Node, annotat
 	return plan, nil
 }
 
-// pushProjection recursively traverses the tree and pushes projection information down
-// - requiredLabels: the set of labels required by parent nodes
-// - isWithout: whether the projection should exclude (true) or include (false) the labels
+// pushProjection recursively traverses the tree and pushes projection information down.
 func (p ProjectionPushdown) pushProjection(node *Node, requiredLabels map[string]struct{}, isWithout bool) {
 	switch n := (*node).(type) {
 	case *VectorSelector:
@@ -123,16 +122,14 @@ func stringSet(s []string) map[string]struct{} {
 	return set
 }
 
-// unwrapStepInvariantExpr recursively unwraps step invariant expressions to get to the underlying node
+// unwrapStepInvariantExpr recursively unwraps step invariant expressions to get to the underlying node.
 func unwrapStepInvariantExpr(node Node) Node {
 	if stepInvariant, ok := node.(*StepInvariantExpr); ok {
 		return unwrapStepInvariantExpr(stepInvariant.Expr)
 	}
 	return node
 }
 
-// getFunctionLabelRequirements ensures that specific labels required by functions are included
-// in the projection
 func getFunctionLabelRequirements(funcName string, args []Node, requiredLabels map[string]struct{}, isWithout bool) map[string]struct{} {
 	if requiredLabels == nil {
 		return nil

logicalplan/projection_pushdown_test.go

@@ -7,9 +7,10 @@ import (
 	"testing"
 	"time"
 
+	"github.com/thanos-io/promql-engine/query"
+
 	"github.com/efficientgo/core/testutil"
 	"github.com/prometheus/prometheus/promql/parser"
-	"github.com/thanos-io/promql-engine/query"
 )
 
 func TestProjectionPushdown(t *testing.T) {