Fix lint when syncing to g3. (#737)

PROCESS

Author: lina128

pose-detection/src/movenet/detector.ts

@@ -44,12 +44,13 @@ class MoveNetDetector implements PoseDetector {
   private readonly enableSmoothing: boolean;
 
   // Global states.
-  private keypointsFilter = new KeypointsOneEuroFilter(KEYPOINT_FILTER_CONFIG);
+  private readonly keypointsFilter =
+      new KeypointsOneEuroFilter(KEYPOINT_FILTER_CONFIG);
+  private readonly cropRegionFilterYMin = new LowPassFilter(CROP_FILTER_ALPHA);
+  private readonly cropRegionFilterXMin = new LowPassFilter(CROP_FILTER_ALPHA);
+  private readonly cropRegionFilterYMax = new LowPassFilter(CROP_FILTER_ALPHA);
+  private readonly cropRegionFilterXMax = new LowPassFilter(CROP_FILTER_ALPHA);
   private cropRegion: BoundingBox;
-  private cropRegionFilterYMin = new LowPassFilter(CROP_FILTER_ALPHA);
-  private cropRegionFilterXMin = new LowPassFilter(CROP_FILTER_ALPHA);
-  private cropRegionFilterYMax = new LowPassFilter(CROP_FILTER_ALPHA);
-  private cropRegionFilterXMax = new LowPassFilter(CROP_FILTER_ALPHA);
 
   constructor(
       private readonly moveNetModel: tfc.GraphModel,
@@ -426,7 +427,7 @@ class MoveNetDetector implements PoseDetector {
    *      image.
    */
   private initCropRegion(imageHeight: number, imageWidth: number) {
-    let boxHeight, boxWidth, yMin, xMin;
+    let boxHeight: number, boxWidth: number, yMin: number, xMin: number;
     if (!this.cropRegion) {
       // If it is the first frame, perform a best guess by making the square
       // crop at the image center to better utilize the image pixels and

pose-detection/src/test_util.ts

@@ -42,7 +42,8 @@ export async function loadVideo(
     videoPath: string, videoFPS: number,
     callback: (video: poseDetection.PoseDetectorInput, timestamp: number) =>
         Promise<poseDetection.Pose[]>,
-    expected: number[][][], model: poseDetection.SupportedModels) {
+    expected: number[][][],
+    model: poseDetection.SupportedModels): Promise<HTMLVideoElement> {
   // We override video's timestamp with a fake timestamp.
   let simulatedTimestamp: number;
   // We keep a pointer for the expected array.
@@ -67,7 +68,7 @@ export async function loadVideo(
   document.body.appendChild(canvas);
   const ctx = canvas.getContext('2d');
 
-  const promise = new Promise((resolve, reject) => {
+  const promise = new Promise<HTMLVideoElement>((resolve, reject) => {
     video.onseeked = async () => {
       const poses = await callback(video, simulatedTimestamp);
       ctx.drawImage(video, 0, 0);
@@ -91,7 +92,7 @@ export async function loadVideo(
         simulatedTimestamp += SIMULATED_INTERVAL;
         idx++;
       } else {
-        resolve();
+        resolve(video);
       }
     };
   });
@@ -135,15 +136,17 @@ function drawSkeleton(
   ctx.strokeStyle = color;
   ctx.lineWidth = 2;
 
-  poseDetection.util.getAdjacentPairs(model).forEach(([i, j]) => {
+  const pairs = poseDetection.util.getAdjacentPairs(model);
+  for (const pair of pairs) {
+    const [i, j] = pair;
     const kp1 = keypoints[i];
     const kp2 = keypoints[j];
 
     ctx.beginPath();
     ctx.moveTo(kp1.x, kp1.y);
     ctx.lineTo(kp2.x, kp2.y);
     ctx.stroke();
-  });
+  }
 }
 
 function draw(

posenet/src/multi_pose/max_heap.ts

@@ -23,9 +23,9 @@ function half(k: number) {
 }
 
 export class MaxHeap<T> {
-  private priorityQueue: T[];
+  private readonly priorityQueue: T[];
+  private readonly getElementValue: (element: T) => number;
   private numberOfElements: number;
-  private getElementValue: (element: T) => number;
 
   constructor(maxSize: number, getElementValue: (element: T) => number) {
     this.priorityQueue = new Array(maxSize);