You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
uploader: request ServerInfo from frontend (#2879)
Summary:
This commit integrates the new `ServerInfo` RPC with the uploader. It’s
not currently enabled by default: the current behavior is the same as
the existing behavior, except that experiment URLs now properly have a
trailing slash. We’ll soon remove the hard-coded API backend endpoint
behavior to enable this by default.
Test Plan:
Running a test frontend and a test backend, we observe the following
behavior with different arguments:
| `--origin` | `--api_endpoint` | → | URL origin | Backend |
|------------|------------------|---|------------|---------|
| empty | empty | | prod | prod |
| empty | prod | | prod | prod |
| empty | test | | prod | test |
| test | empty | | test | test |
| test | test | | test | test |
| test | prod | | test | prod |
Here, “test” in the `--origin` column is like `http://localhost:8080`,
and “test” in the `--api_endpoint` column is like `localhost:10000`.
Note that the no-argument case is equivalent to the explicitly-empty
argument case because both arguments have empty default values.
Explicitly specifying `--origin https://tensorboard.dev`, with any value
of `--api_endpoint`, fails with “Corrupt response from backend” because
server-side support has not yet been rolled out. This is expected.
Specifying `--origin http://localhost:0` or any other unreachable host
fails with `ECONNREFUSED` and a nice message.
My test frontend is configured to reject clients below version 2.0.0 and
warn on clients below version 2.0.1. Changing the local `version.py` to
`2.0.0a0` or `2.0.1a0` exercises these cases.
Finally, double-checked that building the Pip package, installing it,
and running `tensorboard dev list` properly uses the production backend
and prints URLs that resolve to the production frontend.
wchargin-branch: uploader-serverinfo-request
0 commit comments