Skip to content

Commit 869e2b4

Browse files
authored
data: simplify dispatching provider tests (#3858)
Summary: Per comment of @nfelt on #3847, we can still test for delegate equality: <#3847 (comment)> wchargin-branch: data-dispatch-test-bare
1 parent 03b7edf commit 869e2b4

File tree

1 file changed

+4
-16
lines changed

1 file changed

+4
-16
lines changed

tensorboard/data/dispatching_provider_test.py

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -287,14 +287,8 @@ def test_blob_sequences_prefixed(self):
287287
self.assertEqual(listing, expected_listing)
288288

289289
blobs = self._get_blobs(self.with_unpfx, "bar:a:b:c")
290-
self.assertEqual(
291-
blobs,
292-
{
293-
"a:b:c/test": {
294-
"input.images": [[b"experiment: a:b:c", b"name: Bar"]]
295-
}
296-
},
297-
)
290+
expected_blobs = self._get_blobs(self.bar_provider, "a:b:c")
291+
self.assertEqual(blobs, expected_blobs)
298292

299293
def test_blob_sequences_unprefixed(self):
300294
listing = self.with_unpfx.list_blob_sequences(
@@ -306,14 +300,8 @@ def test_blob_sequences_unprefixed(self):
306300
self.assertEqual(listing, expected_listing)
307301

308302
blobs = self._get_blobs(self.with_unpfx, "baz")
309-
self.assertEqual(
310-
blobs,
311-
{
312-
"baz/test": {
313-
"input.images": [[b"experiment: baz", b"name: BAZ"]]
314-
}
315-
},
316-
)
303+
expected_blobs = self._get_blobs(self.baz_provider, "baz")
304+
self.assertEqual(blobs, expected_blobs)
317305

318306
def test_blobs_error_cases(self):
319307
with self.assertRaisesRegex(

0 commit comments

Comments
 (0)