You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
We’ve deployed production servers that support the handshake protocol
specified in #2878 and implemented on the client in #2879. This commit
enables that protocol by default.
Test Plan:
Running `bazel run //tensorboard -- dev list` still properly connects
and prints valid URLs. Re-running with the TensorBoard version patched
to `2.0.0a0` (in `version/version.py`) properly causes a handshake
failure. Setting `--origin` to point to a non-prod frontend properly
connects to the appropriate backend. Setting `--api_endpoint` to point
to a non-prod backend connects directly, skipping the handshake, and
printing `https://tensorboard.dev` URLs. Specifying both `--origin` and
`--api_endpoint` performs the handshake and overrides the backend
server only, printing URLs corresponding to the listed frontend.
Running `git grep api.tensorboard.dev` no longer finds any code results.
As a double check, building the Pip package and running it in a new
virtualenv still has a working `tensorboard dev upload` flow.
wchargin-branch: uploader-handshake
0 commit comments