Skip to content

Commit 717dec8

Browse files
authored
Update data server build step to run with ubuntu 20.04 and change platform tag (#6636)
This should ensure that the generated wheels are compatible with the `manylinux_2_31` platform tag, since that's the version of `glibc` shipped with ubuntu 20.04. This aligns us with https://peps.python.org/pep-0600/ instead of reconfiguring our CI workflow to build on a system with `glibc<=2.17` to keep supporting the `manylinux2014` tag (https://peps.python.org/pep-0599/).
1 parent 945710f commit 717dec8

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,11 +142,11 @@ jobs:
142142
fail-fast: false
143143
matrix:
144144
mode: ['native']
145-
platform: ['ubuntu-22.04', 'macos-12']
145+
platform: ['ubuntu-20.04', 'macos-12']
146146
rust_version: ['1.65.0']
147147
include:
148148
- mode: 'universal'
149-
platform: 'ubuntu-22.04'
149+
platform: 'ubuntu-20.04'
150150
rust_version: '1.65.0'
151151
steps:
152152
- uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0

tensorboard/data/server/pip_package/build.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,9 @@ def main():
3737
if cpu_name == "arm64":
3838
mac_platform = "macosx_11_0"
3939
platform_name = {
40-
# using platform tag values from TensorFlow releases
41-
"Linux": "manylinux2014",
40+
# We build on an Ubuntu 20.04 (Focal Fossa) image, which ships with
41+
# glibc 2.31 (https://launchpad.net/ubuntu/focal/+source/glibc).
42+
"Linux": "manylinux_2_31",
4243
"Darwin": mac_platform,
4344
}.get(platform.system())
4445

0 commit comments

Comments
 (0)