Skip to content

Commit 1e7c972

Browse files
authored
Add scrolling functionality to feature flag page (#5994)
* Motivation for features / changes In hosted services we have too many flags to fit on many screens. Before this change that meant the bottom flags and the reset button were cut off. Now we can scroll down to see all flags and the reset button. * Screenshots of UI changes ![2022-10-24_16-43-09 (1)](https://user-images.githubusercontent.com/8672809/197650840-f5293cbf-dfdb-40b9-bc14-c64336d57102.gif)
1 parent 70273bf commit 1e7c972

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

tensorboard/webapp/feature_flag/views/feature_flag_page_component.ng.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
limitations under the License.
1616
-->
1717

18-
<div>
18+
<div class="scrolling-page">
1919
<div class="message">
2020
<h2 class="warning">WARNING: EXPERIMENTAL FEATURES AHEAD!</h2>
2121
By enabling these features, you could put the application in an unusable

tensorboard/webapp/feature_flag/views/feature_flag_page_component.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@ limitations under the License.
2222
margin-bottom: 16px;
2323
}
2424

25+
.scolling-page {
26+
height: 90vh;
27+
overflow-y: scroll;
28+
}
29+
2530
.feature-flag-table {
2631
width: 100%;
2732
}

0 commit comments

Comments
 (0)