Skip to content

Commit 55c4d36

Browse files
hehaifengcnmindaugasrukas
authored andcommitted
Restore defaultListWorkflowsPageSize back to 1000 (from 100) (#4674)
<!-- Describe what has changed in this PR --> **What changed?** <!-- Tell your future self why have you made these changes --> **Why?** GenerateReplicationTasks and VerifyReplicationTasks runs in parallel. VerifyReplicationTasks runs every 2s. Verification is not instantaneous, which means for every batch, Verification can delay at least 5s. Increase batch size, reduce the ration of the delay in batch processing. Before the change, RPS for GenerateReplicationTasks + VerifyReplicationTasks is 30 RPS. With the change RPS is 90. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** Cluster test. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** Yes.
1 parent 91a3146 commit 55c4d36

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

service/worker/migration/force_replication_workflow.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ const (
133133
taskQueueUserDataReplicationDoneSignalType = "task-queue-user-data-replication-done"
134134
taskQueueUserDataReplicationVersionMarker = "replicate-task-queue-user-data"
135135

136-
defaultListWorkflowsPageSize = 100
136+
defaultListWorkflowsPageSize = 1000
137137
defaultPageCountPerExecution = 200
138138
maxPageCountPerExecution = 1000
139139
defaultPageSizeForTaskQueueUserDataReplication = 20

0 commit comments

Comments
 (0)