Skip to content

Commit 2237e72

Browse files
committed
Remove ActivityCountOptions
1 parent 3a85617 commit 2237e72

5 files changed

Lines changed: 3 additions & 54 deletions

File tree

temporal-sdk/src/main/java/io/temporal/client/ActivityClient.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1607,15 +1607,6 @@ <R> ActivityHandle<R> getHandle(
16071607
*/
16081608
ActivityExecutionCount countExecutions(String query);
16091609

1610-
/**
1611-
* Returns the count of activity executions matching the given query, with options.
1612-
*
1613-
* @param query Temporal visibility query string
1614-
* @param options count options
1615-
* @return execution count, optionally with aggregation groups
1616-
*/
1617-
ActivityExecutionCount countExecutions(String query, ActivityCountOptions options);
1618-
16191610
/**
16201611
* Creates a new {@link ActivityCompletionClient} for completing activities asynchronously using a
16211612
* task token or activity ID.

temporal-sdk/src/main/java/io/temporal/client/ActivityClientImpl.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -424,13 +424,8 @@ public Stream<ActivityExecutionMetadata> listExecutions(
424424

425425
@Override
426426
public ActivityExecutionCount countExecutions(String query) {
427-
return countExecutions(query, ActivityCountOptions.newBuilder().build());
428-
}
429-
430-
@Override
431-
public ActivityExecutionCount countExecutions(String query, ActivityCountOptions options) {
432427
return invoker
433-
.countActivities(new ActivityClientCallsInterceptor.CountActivitiesInput(query, options))
428+
.countActivities(new ActivityClientCallsInterceptor.CountActivitiesInput(query))
434429
.getCount();
435430
}
436431

temporal-sdk/src/main/java/io/temporal/client/ActivityCountOptions.java

Lines changed: 0 additions & 28 deletions
This file was deleted.

temporal-sdk/src/main/java/io/temporal/common/interceptors/ActivityClientCallsInterceptor.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package io.temporal.common.interceptors;
22

33
import io.temporal.client.ActivityAlreadyStartedException;
4-
import io.temporal.client.ActivityCountOptions;
54
import io.temporal.client.ActivityExecutionCount;
65
import io.temporal.client.ActivityExecutionDescription;
76
import io.temporal.client.ActivityExecutionMetadata;
@@ -435,20 +434,14 @@ public ActivityListPage getPage() {
435434
@Experimental
436435
final class CountActivitiesInput {
437436
private final String query;
438-
private final ActivityCountOptions options;
439437

440-
public CountActivitiesInput(String query, ActivityCountOptions options) {
438+
public CountActivitiesInput(String query) {
441439
this.query = query;
442-
this.options = options;
443440
}
444441

445442
public String getQuery() {
446443
return query;
447444
}
448-
449-
public ActivityCountOptions getOptions() {
450-
return options;
451-
}
452445
}
453446

454447
@Experimental

temporal-sdk/src/test/java/io/temporal/common/interceptors/ActivityClientCallsInterceptorBaseTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import static org.junit.Assert.*;
44
import static org.mockito.Mockito.*;
55

6-
import io.temporal.client.ActivityCountOptions;
76
import io.temporal.client.ActivityExecutionCount;
87
import io.temporal.client.ActivityExecutionDescription;
98
import io.temporal.client.ActivityExecutionMetadata;
@@ -145,8 +144,7 @@ public void testCountActivitiesDelegatesToNext() {
145144
CountActivitiesOutput output = new CountActivitiesOutput(count);
146145
when(next.countActivities(any(CountActivitiesInput.class))).thenReturn(output);
147146

148-
CountActivitiesInput input =
149-
new CountActivitiesInput("query", ActivityCountOptions.newBuilder().build());
147+
CountActivitiesInput input = new CountActivitiesInput("query");
150148
CountActivitiesOutput result = base.countActivities(input);
151149

152150
assertSame(output, result);

0 commit comments

Comments
 (0)