Skip to content

Commit 7ed502c

Browse files
committed
Do not mark SideEffectOptions and MutableSideEffectOptions as experimental, only Summary field is experimental
1 parent 31a4877 commit 7ed502c

File tree

3 files changed

+0
-20
lines changed

3 files changed

+0
-20
lines changed

internal/interceptor.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -298,8 +298,6 @@ type WorkflowOutboundInterceptor interface {
298298
SideEffect(ctx Context, f func(ctx Context) interface{}) converter.EncodedValue
299299

300300
// SideEffectWithOptions intercepts workflow.SideEffectWithOptions.
301-
//
302-
// NOTE: Experimental
303301
SideEffectWithOptions(ctx Context, options SideEffectOptions, f func(ctx Context) interface{}) converter.EncodedValue
304302

305303
// MutableSideEffect intercepts workflow.MutableSideEffect.
@@ -311,8 +309,6 @@ type WorkflowOutboundInterceptor interface {
311309
) converter.EncodedValue
312310

313311
// MutableSideEffectWithOptions intercepts workflow.MutableSideEffectWithOptions.
314-
//
315-
// NOTE: Experimental
316312
MutableSideEffectWithOptions(
317313
ctx Context,
318314
id string,

internal/workflow.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -607,8 +607,6 @@ type (
607607

608608
// SideEffectOptions are options for executing a side effect.
609609
//
610-
// NOTE: Experimental
611-
//
612610
// Exposed as: [go.temporal.io/sdk/workflow.SideEffectOptions]
613611
SideEffectOptions struct {
614612
// Summary is a single-line summary of this side effect that will appear in UI/CLI.
@@ -622,8 +620,6 @@ type (
622620

623621
// MutableSideEffectOptions are options for executing a mutable side effect.
624622
//
625-
// NOTE: Experimental
626-
//
627623
// Exposed as: [go.temporal.io/sdk/workflow.MutableSideEffectOptions]
628624
MutableSideEffectOptions struct {
629625
// Summary is a single-line summary of this side effect that will appear in UI/CLI.
@@ -2099,8 +2095,6 @@ func SideEffect(ctx Context, f func(ctx Context) interface{}) converter.EncodedV
20992095
//
21002096
// The options parameter allows specifying additional options like a summary that will be displayed in UI/CLI.
21012097
//
2102-
// NOTE: Experimental
2103-
//
21042098
// Exposed as: [go.temporal.io/sdk/workflow.SideEffectWithOptions]
21052099
func SideEffectWithOptions(ctx Context, options SideEffectOptions, f func(ctx Context) interface{}) converter.EncodedValue {
21062100
assertNotInReadOnlyState(ctx)
@@ -2163,8 +2157,6 @@ func MutableSideEffect(ctx Context, id string, f func(ctx Context) interface{},
21632157
//
21642158
// The options parameter allows specifying additional options like a summary that will be displayed in UI/CLI.
21652159
//
2166-
// NOTE: Experimental
2167-
//
21682160
// Exposed as: [go.temporal.io/sdk/workflow.MutableSideEffectWithOptions]
21692161
func MutableSideEffectWithOptions(ctx Context, id string, options MutableSideEffectOptions, f func(ctx Context) interface{}, equals func(a, b interface{}) bool) converter.EncodedValue {
21702162
assertNotInReadOnlyState(ctx)

workflow/workflow.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -124,13 +124,9 @@ type (
124124
UpdateHandlerOptions = internal.UpdateHandlerOptions
125125

126126
// SideEffectOptions are options for executing a side effect.
127-
//
128-
// NOTE: Experimental
129127
SideEffectOptions = internal.SideEffectOptions
130128

131129
// MutableSideEffectOptions are options for executing a mutable side effect.
132-
//
133-
// NOTE: Experimental
134130
MutableSideEffectOptions = internal.MutableSideEffectOptions
135131

136132
// NOTE to maintainers, this interface definition is duplicated in the internal package to provide a better UX.
@@ -409,8 +405,6 @@ func SideEffect(ctx Context, f func(ctx Context) interface{}) converter.EncodedV
409405
// This guarantees the deterministic requirement for workflow as the exact same result will be returned in replay.
410406
//
411407
// The options parameter allows specifying additional options like a summary that will be displayed in UI/CLI.
412-
//
413-
// NOTE: Experimental
414408
func SideEffectWithOptions(ctx Context, options SideEffectOptions, f func(ctx Context) interface{}) converter.EncodedValue {
415409
return internal.SideEffectWithOptions(ctx, options, f)
416410
}
@@ -436,8 +430,6 @@ func MutableSideEffect(ctx Context, id string, f func(ctx Context) interface{},
436430

437431
// MutableSideEffectWithOptions is like MutableSideEffect but allows specifying additional options
438432
// like a summary that will be displayed in UI/CLI.
439-
//
440-
// NOTE: Experimental
441433
func MutableSideEffectWithOptions(ctx Context, id string, options MutableSideEffectOptions, f func(ctx Context) interface{}, equals func(a, b interface{}) bool) converter.EncodedValue {
442434
return internal.MutableSideEffectWithOptions(ctx, id, options, f, equals)
443435
}

0 commit comments

Comments
 (0)