Don't expose metric const publicly

Author: yuandrew

contrib/resourcetuner/resourcetuner.go

@@ -17,8 +17,8 @@ import (
 
 // Metric names emitted by the resource-based tuner
 const (
-	ResourceSlotsCPUUsage = "temporal_resource_slots_cpu_usage"
-	ResourceSlotsMemUsage = "temporal_resource_slots_mem_usage"
+	resourceSlotsCPUUsage = "temporal_resource_slots_cpu_usage"
+	resourceSlotsMemUsage = "temporal_resource_slots_mem_usage"
 )
 
 type ResourceBasedTunerOptions struct {
@@ -326,8 +326,8 @@ func (rc *ResourceController) publishResourceMetrics(metricsHandler client.Metri
 	if metricsHandler == nil {
 		return
 	}
-	metricsHandler.Gauge(ResourceSlotsMemUsage).Update(memUsage * 100)
-	metricsHandler.Gauge(ResourceSlotsCPUUsage).Update(cpuUsage * 100)
+	metricsHandler.Gauge(resourceSlotsMemUsage).Update(memUsage * 100)
+	metricsHandler.Gauge(resourceSlotsCPUUsage).Update(cpuUsage * 100)
 }
 
 type psUtilSystemInfoSupplier struct {

contrib/resourcetuner/resourcetuner_test.go

@@ -86,8 +86,8 @@ func TestPidDecisionEmitsUsageMetrics(t *testing.T) {
 		gaugesByName[gauge.Name] = gauge.Value()
 	}
 
-	assert.Equal(t, 25.0, gaugesByName[ResourceSlotsMemUsage])
-	assert.Equal(t, 75.0, gaugesByName[ResourceSlotsCPUUsage])
+	assert.Equal(t, 25.0, gaugesByName[resourceSlotsMemUsage])
+	assert.Equal(t, 75.0, gaugesByName[resourceSlotsCPUUsage])
 
 	fakeSupplier.memUse = 0.7
 	fakeSupplier.cpuUse = 0.9
@@ -102,6 +102,6 @@ func TestPidDecisionEmitsUsageMetrics(t *testing.T) {
 		gaugesByName[gauge.Name] = gauge.Value()
 	}
 
-	assert.Equal(t, 70.0, gaugesByName[ResourceSlotsMemUsage])
-	assert.Equal(t, 90.0, gaugesByName[ResourceSlotsCPUUsage])
+	assert.Equal(t, 70.0, gaugesByName[resourceSlotsMemUsage])
+	assert.Equal(t, 90.0, gaugesByName[resourceSlotsCPUUsage])
 }