Skip to content

Commit 1b513da

Browse files
authored
Merge branch 'master' into cleanup-nightly-tps-workflow
2 parents 72a2879 + 5cd20cf commit 1b513da

File tree

4 files changed

+23
-7
lines changed

4 files changed

+23
-7
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ on:
55
branches:
66
- master
77

8+
permissions:
9+
contents: read
10+
811
jobs:
912
build-and-test:
1013
strategy:
@@ -23,6 +26,10 @@ jobs:
2326
runsOn: macos-15-intel
2427
- os: macos-arm
2528
runsOn: macos-14
29+
permissions:
30+
contents: read
31+
checks: write
32+
statuses: write
2633
runs-on: ${{ matrix.runsOn || matrix.os }}
2734
steps:
2835
- name: Checkout repository

.github/workflows/nightly-throughput-stress.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ on:
2727
type: number
2828

2929
permissions:
30-
contents: read
30+
contents: read
3131

3232
env:
3333
# Workflow configuration
@@ -46,6 +46,9 @@ jobs:
4646
throughput-stress:
4747
runs-on: ubuntu-latest-4-cores
4848
timeout-minutes: ${{ fromJSON(inputs.job_timeout_minutes || (vars.NIGHTLY_JOB_TIMEOUT_MINUTES || '360')) }}
49+
permissions:
50+
contents: read
51+
actions: write
4952

5053
steps:
5154
- name: Print test configuration
@@ -149,4 +152,4 @@ jobs:
149152
]
150153
}
151154
env:
152-
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_SDK_ALERTS_WEBHOOK }}
155+
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_SDK_ALERTS_WEBHOOK }}

.github/workflows/omes.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,14 @@ on:
44
branches:
55
- master
66

7+
permissions:
8+
contents: read
9+
710
jobs:
811
omes-image-build:
12+
permissions:
13+
contents: read
14+
packages: write
915
uses: temporalio/omes/.github/workflows/docker-images.yml@main
1016
secrets: inherit
1117
with:
@@ -14,4 +20,4 @@ jobs:
1420
sdk-repo-ref: ${{ github.event.pull_request.head.ref || github.ref }}
1521
# TODO: Remove once we have a good way of cleaning up sha-based pushed images
1622
docker-tag-ext: ci-latest
17-
do-push: true
23+
do-push: true

contrib/envconfig/client_config_load.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ func LoadDefaultClientOptions() (client.Options, error) {
3232
// LoadClientOptionsRequest are options for [LoadClientOptions].
3333
type LoadClientOptionsRequest struct {
3434
// Override the file path to use to load the TOML file for config. Defaults to TEMPORAL_CONFIG_FILE environment
35-
// variable or if that is unset/empty, defaults to [os.UserConfigDir]/temporal/temporal.toml. If ConfigFileData is
35+
// variable or if that is unset/empty, defaults to [os.UserConfigDir]/temporalio/temporal.toml. If ConfigFileData is
3636
// set, this cannot be set and no file loading from disk occurs. Ignored if DisableFile is true.
3737
ConfigFilePath string
3838

@@ -93,7 +93,7 @@ func LoadClientOptions(options LoadClientOptionsRequest) (client.Options, error)
9393
// [LoadClientConfigOptions] are options for [LoadClientConfig].
9494
type LoadClientConfigOptions struct {
9595
// Override the file path to use to load the TOML file for config. Defaults to TEMPORAL_CONFIG_FILE environment
96-
// variable or if that is unset/empty, defaults to [os.UserConfigDir]/temporal/temporal.toml. If ConfigFileData is
96+
// variable or if that is unset/empty, defaults to [os.UserConfigDir]/temporalio/temporal.toml. If ConfigFileData is
9797
// set, this cannot be set and no file loading from disk occurs.
9898
ConfigFilePath string
9999

@@ -158,7 +158,7 @@ func LoadClientConfig(options LoadClientConfigOptions) (ClientConfig, error) {
158158
// LoadClientConfigProfileOptions are options for [LoadClientConfigProfile].
159159
type LoadClientConfigProfileOptions struct {
160160
// Override the file path to use to load the TOML file for config. Defaults to TEMPORAL_CONFIG_FILE environment
161-
// variable or if that is unset/empty, defaults to [os.UserConfigDir]/temporal/temporal.toml. If ConfigFileData is
161+
// variable or if that is unset/empty, defaults to [os.UserConfigDir]/temporalio/temporal.toml. If ConfigFileData is
162162
// set, this cannot be set and no file loading from disk occurs. Ignored if DisableFile is true.
163163
ConfigFilePath string
164164

@@ -248,7 +248,7 @@ func LoadClientConfigProfile(options LoadClientConfigProfileOptions) (ClientConf
248248
// DefaultConfigFileProfile is the default profile used.
249249
const DefaultConfigFileProfile = "default"
250250

251-
// DefaultConfigFilePath is the default config file path used. It is [os.UserConfigDir]/temporal/temporal.toml.
251+
// DefaultConfigFilePath is the default config file path used. It is [os.UserConfigDir]/temporalio/temporal.toml.
252252
//
253253
// WARNING: Environment configuration is currently experimental.
254254
func DefaultConfigFilePath() (string, error) {

0 commit comments

Comments
 (0)