Skip to content

Commit 546d09f

Browse files
committed
Fix protobuf syntax that is causing an error in protobufjs (#589)
**What changed?** - Fix a double semicolon introduced in #579. **Why?** - The double semicolon sequence is causing a compilation error in `protobufjs`, even though this is technically valid according to [the official Protobuf 3 spec](https://protobuf.dev/reference/protobuf/proto3-spec/#emptystatement). This is a bug in `protobufjs`, for which there's been [an open issue ticket](protobufjs/protobuf.js#1322) since 2019, but it was never acknowledged, and a PR fixing this has been ignored for more than a year. Given that there's simply no reason to use a double semicolon sequence anyway, it appears preferable to simply avoid that in our proto definitions.
1 parent aef6069 commit 546d09f

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

temporalproto/openapi/openapiv2.go

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

temporalproto/openapi/openapiv3.go

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)