Skip to content

Commit 218ccbf

Browse files
spkane31yycptt
authored andcommitted
bug: add timestamp to TriggerImmediatelyRequest (#606)
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** adding a timestamp to `TriggerImmediatelyRequest` message <!-- Tell your future self why have you made these changes --> We can make the wft “more idempotent”: put the desired trigger time in the trigger immediately request itself, so it goes in the signal payload, so all wfts attempt to start the target with the same id. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> [**Server PR**](temporalio/temporal#7968)
1 parent 67eaf88 commit 218ccbf

File tree

7 files changed

+494
-105
lines changed

7 files changed

+494
-105
lines changed

.gitmodules

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
[submodule "proto/api"]
22
path = proto/api
33
url = https://github.com/temporalio/api
4+
branch = release/v1.50.x
45
[submodule "proto/api-cloud"]
56
path = proto/api-cloud
67
url = https://github.com/temporalio/api-cloud

operatorservice/v1/service.pb.gw.go

Lines changed: 36 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

schedule/v1/message.pb.go

Lines changed: 40 additions & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

temporalproto/openapi/openapiv2.go

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

temporalproto/openapi/openapiv3.go

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)