Sync with Kendo UI Professional

Author: kendo-bot

docs/controls/autocomplete/accessibility/overview.md

@@ -8,7 +8,7 @@ position: 1
 
 # AutoComplete Accessibility
 
-The AutoComplete is accessible by screen readers and provides WAI-ARIA, Section 508, WCAG 2.2, and keyboard support.
+The AutoComplete is accessible by screen readers and provides WAI-ARIA, Section 508, WCAG 2.1, and keyboard support.
 
 > According to [WAI-ARIA 1.1](https://www.w3.org/TR/wai-aria/#combobox) specification *"Authors must ensure an element with role combobox contains or owns a text input element with role textbox or searchbox..."*. Note, that in our implementation, the text input element is the one that has role="combobox", and does not contain another text input element. **This approach is valid for the [WAI-ARIA 1.2](https://www.w3.org/TR/wai-aria-1.2/#combobox) specification and also for the [WAI-ARIA 1.0](https://www.w3.org/TR/wai-aria/#combobox) specification .**
 >
@@ -29,46 +29,54 @@ The AutoComplete is compliant with the [Web Content Accessibility Guidelines (WC
 ## WAI-ARIA
 
 
-The following table lists the selectors, attributes, and behavior patterns supported by the AutoComplete component:
+This section lists the selectors, attributes, and behavior patterns supported by the component and its composite elements, if any.
 
-### AutoComplete wrapper
+### AutoComplete Wrapping Element
+
+
+The following table summarizes the selectors and attributes supported by the AutoComplete wrapper element:
 
 | Selector | Attribute | Usage |
 | -------- | --------- | ----- |
-| `.k-input-inner` | `role=combobox` | Announces the presence of a autocomplete as inner element of the autocomplete used for filtering. |
-|  | `label for` or `aria-label` or `aria-labelledby` | The input needs an accessible name to be assigned to it. |
-|  | `aria-haspopup=listbox` | Indicates the component has a listbox Popup. |
-|  | `aria-expanded=true/false` | Announces the state of the visibility of the popup. |
-|  | `aria-controls=.k-list-ul id` | Points to the listbox element. Signifies that the `combobox` element controls the `listbox`. |
-|  | `aria-activedescendant=.k-list-item.k-focus id` | Points to the focused item in the popup. The focused item is changed via keyboard navigation. If the popup is not visible, the attribute should not point to any element or should be removed. |
-|  | `aria-autocomplete=list` | Attribute is rendered and value is set to list when **filtering** feature is enabled. |
-|  | `aria-autocomplete=both` | Attribute is rendered and value is set to both when both **filtering** and **suggest** features are enabled. |
-|  | `aria-autocomplete=inline` | Attribute is rendered and value is set to only **suggest** feature is enabled. |
-|  | `readonly` or `aria-readonly` | Attribute is rendered only when the autocomplete is readonly. |
-|  | `aria-busy=true` | Attribute is rendered only when the autocomplete is loading data. |
+| `.k-input-inner` | `role=combobox` | Announces the presence of an AutoComplete as the inner element of the AutoComplete that is used for filtering. |
+|  | `label for` or `aria-label` or `aria-labelledby` | The input needs an accessible name that will be assigned to it. |
+|  | `aria-haspopup=listbox` | Indicates that the component has a listbox popup. |
+|  | `aria-expanded=true/false` | Announces the state of the popup visibility. |
+|  | `aria-controls=.k-list-ul id` | Points to the `listbox` element. Signifies that the `combobox` element controls the `listbox` one. |
+|  | `aria-activedescendant=.k-list-item.k-focus id` | Points to the focused item in the popup. The focused item is changed with keyboard navigation. If the popup is not visible, the attribute must not point to any element or must be removed. |
+|  | `aria-autocomplete=list` | The attribute is rendered and the value is set to `list` when the filtering feature is enabled. |
+|  | `aria-autocomplete=both` | The attribute is rendered and the value is set to `both` when both the filtering and suggest features are enabled. |
+|  | `aria-autocomplete=inline` | The attribute is rendered and the value is set to `only` when the suggest feature is enabled. |
+|  | `readonly` or `aria-readonly` | The attribute is rendered only when the AutoComplete is read-only. |
+|  | `aria-busy=true` | The attribute is rendered only when the AutoComplete is loading data. |
 |  | `tabindex=0` | The element must be focusable. |
-| `.k-invalid .k-input-inner,.ng-invalid .k-input-inner` | `aria-invalid=true` | Attribute is rendered only when the autocomplete is in form and announces the valid state of the component. |
-| `.k-disabled .k-input-inner` | `disabled=disabled` or `aria-disabled=true` | Attribute is rendered only when the autocomplete is disabled. |
+| `.k-invalid .k-input-inner,.ng-invalid .k-input-inner` | `aria-invalid=true` | The attribute is rendered only when the AutoComplete is in a form and announces the valid state of the component. |
+| `.k-disabled .k-input-inner` | `disabled=disabled` or `aria-disabled=true` | The attribute is rendered only when the AutoComplete is disabled. |
 
-### ListBox Popup
+### Popup Listbox
 
 
-The Popup element of the component should implement the specification for a **Popup List** component.
+The popup element of the AutoComplete has to implement the WAI-ARIA specification for a Popup List component. The following table summarizes the selectors and attributes supported by the listbox popup of the AutoComplete:
 
 | Selector | Attribute | Usage |
 | -------- | --------- | ----- |
-| `.k-animation-container` | `role=region` | When the component container is appended to the `<body>` element of the document, it needs a landmark role to be assigned to it. Otherwise, it should be appended to an element with an appropriate landmark role. |
-|  | `aria-label` or `aria-labelledby` | Provides a label when the container has a `region` role assigned. |
-| `.k-list-ul` | `role=listbox` | Identifies the ul element as a listbox. |
-|  | `aria-label` or `aria-labelledby` |  Provides a label for the listbox of the combobox. |
-| `.k-list-item` | `role=option` | Identifies the li element as a listbox option. |
+| `.k-animation-container` | `role=region` | When the component container is appended to the `<body>` element of the document, it requires you to assing a `landmark` role to it. Otherwise, append it to an element with an appropriate `landmark` role. |
+|  | `aria-label` or `aria-labelledby` | When the container has a `region` role assigned, povides a label. |
+| `.k-list-ul` | `role=listbox` | Identifies the `ul` element as a listbox. |
+|  | `aria-label` or `aria-labelledby` | Provides a label for the listbox of the ComboBox. |
+| `.k-list-item` | `role=option` | Identifies the `li` element as a listbox option. |
+|  | `id` | When grouped, the list items must have an `id` attribute specified, so that the `aria-owns` attribute of their group header elements (with `role=group`) point to that ids. |
+|  | `aria-describedby` | When grouped, the list items must have an `aria-describedby` attribute pointing to the id of the `k-list-item-text` element in their `k-list-group-item`. |
 | `.k-list-item.k-selected` | `aria-selected=true` | Indicates the selected state of the item. |
+| `.k-list-group-item` | `role=group` | The group elements in the popup list must be have `role=group`. |
+|  | `aria-owns` | The group elements in the popup list must own the list items belonging to their group. |
+| `.k-list-group-item>.k-list-item-text` | `id` | The `k-list-item-text` elements of the `k-list-group-item` must have an id specified. The `aria-labelledby` attribute of the list items in the group must point to that id. |
 
 ## Resources
 
-[ARIA practices: Editable Combobox With Both List and Inline Autocomplete Example](https://www.w3.org/WAI/ARIA/apg/example-index/combobox/combobox-autocomplete-both.html)
+[WAI-ARIA Authoring Practices: Editable Combobox With Both List and Inline Autocomplete Example](https://www.w3.org/WAI/ARIA/apg/example-index/combobox/combobox-autocomplete-both.html)
 
-[ARIA Practices: Editable Combobox With List Autocomplete Example](https://www.w3.org/WAI/ARIA/apg/example-index/combobox/combobox-autocomplete-list.html)
+[WAI-ARIA Authoring Practices: Editable Combobox With List Autocomplete Example](https://www.w3.org/WAI/ARIA/apg/example-index/combobox/combobox-autocomplete-list.html)
 
 ## Section 508
 

package-lock.json

@@ -64,6 +64,7 @@
   },
   "overrides": {
     "chokidar": "^3.0.0",
+    "braces": "~3.0.3",
     "glob-stream": "^8.0.0",
     "micromatch": "^4.0.0",
     "word-wrap": ">=1.2.4",

package.json

@@ -21,6 +21,10 @@ const globals = {
     jquery: '$'
 };
 
+// Used only for the source code bundle.
+const babelArg = process.argv.includes("--configBabel");
+const babel = babelArg ? require('@rollup/plugin-babel') : null;
+
 export function transformCodePlugin() {
     return {
         name: 'transform-kendo-modules',
@@ -73,7 +77,8 @@ const resourcesConfig = (name, options = {}) => ({
     plugins: [
         transformCodePlugin(),
         addKendoVersion(),
-        polyfill(['../kendo.core.js'])
+        polyfill(['../kendo.core.js']),
+        babel ? babel({ babelHelpers: 'bundled' }) : null // Used only for the source code bundle.
     ]
 });
 
@@ -95,7 +100,8 @@ const configMap = (name) => ({
         transformCodePlugin(),
         addKendoVersion(),
         name === 'kendo.core.js' || isBundle(name) ? polyfill(['jquery']) : null,
-        nodeResolve()
+        nodeResolve(),
+        babel ? babel({ babelHelpers: 'bundled' }) : null // Used only for the source code bundle.
     ]
 });
 

rollup.config.js

@@ -116,7 +116,7 @@ var __meta__ = {
         }
 
         if (data.iconSize) {
-            inlineStyles.fontSize = data.iconSize;
+            inlineStyles.fontSize = data.iconSize + "px";
         }
 
         if (Object.keys(inlineStyles).length) {

src/kendo.actionsheet.js

@@ -751,7 +751,9 @@ import "./kendo.icons.js";
                         modal.options.appendTo === that.options.appendTo &&
                         !modal.containment &&
                         $(modal.element).is(VISIBLE);
-                }).sort(function(a, b) {
+                });
+
+                zStack = [].sort.call(zStack, function(a, b) {
                     return +$(a).css("zIndex") - +$(b).css("zIndex");
                 });
 

src/kendo.dialog.js

@@ -1292,7 +1292,7 @@ var __meta__ = {
             var items = that.getItems();
             var offset = options.offset;
             var indecesInDom = getSortedDomIndices(items);
-            var movedItems = $.makeArray(items.sort(that.itemComparer));
+            var movedItems = $.makeArray([].sort.call(items,that.itemComparer));
             var moveAction = options.moveAction;
             var movedItem;
 

src/kendo.listbox.js

@@ -788,7 +788,7 @@ var __meta__ = {
             });
 
             if (this.element.is("[tabindex]")) {
-                elements.push(this.element[0]);
+                [].push.call(elements, this.element[0]);
             }
 
             return elements;
@@ -797,7 +797,7 @@ var __meta__ = {
             var sortedElements;
 
             if (stableSort) {
-                sortedElements = elements.sort(function(prev, next) {
+                sortedElements = [].sort.call(elements, function(prev, next) {
                     return prev.tabIndex - next.tabIndex;
                 });
             } else {
@@ -806,7 +806,7 @@ var __meta__ = {
                     item.setAttribute(attrName, i);
                 });
 
-                sortedElements = elements.sort(function(prev, next) {
+                sortedElements = [].sort.call(elements, function(prev, next) {
                     return prev.tabIndex === next.tabIndex ?
                         parseInt(prev.getAttribute(attrName), 10) - parseInt(next.getAttribute(attrName), 10) :
                         prev.tabIndex - next.tabIndex;

src/kendo.popup.js

@@ -100,7 +100,7 @@
 
             var AnotherBall = Ball.extend();
 
-            assert.isOk($.isArray(AnotherBall.fn.colors));
+            assert.isOk(Array.isArray(AnotherBall.fn.colors));
         });
 
     });

tests/core/class.js

@@ -9,7 +9,7 @@
 
         it("stringified object should be deserializable ", function() {
             var obj = { foo: "bar", baz: 1 };
-            var result = $.parseJSON(kendo.stringify(obj));
+            var result = JSON.parse(kendo.stringify(obj));
             assert.equal(result.foo, "bar");
             assert.equal(result.baz, 1);
         });

tests/core/json.js

@@ -354,7 +354,7 @@
                 sort: { field: "foo", dir: "asc" }
             });
 
-            assert.isOk($.isArray(dataSource._sort));
+            assert.isOk(Array.isArray(dataSource._sort));
             assert.equal(dataSource._sort[0].field, "foo");
             assert.equal(dataSource._sort[0].dir, "asc");
         });

tests/data/datasource/initialization.js

@@ -65,7 +65,7 @@
         it("pushCreate option is passed to the push method", function() {
             var transport = {
                 push: function(options) {
-                    assert.isOk($.isFunction(options.pushCreate));
+                    assert.isOk(kendo.isFunction(options.pushCreate));
                 }
             };
 
@@ -75,7 +75,7 @@
         it("pushUpdate option is passed to the push method", function() {
             var transport = {
                 push: function(options) {
-                    assert.isOk($.isFunction(options.pushUpdate));
+                    assert.isOk(kendo.isFunction(options.pushUpdate));
                 }
             };
 
@@ -85,7 +85,7 @@
         it("pushDestroy option is passed to the push method", function() {
             var transport = {
                 push: function(options) {
-                    assert.isOk($.isFunction(options.pushDestroy));
+                    assert.isOk(kendo.isFunction(options.pushDestroy));
                 }
             };
 

tests/data/datasource/push.js

@@ -63,7 +63,7 @@
             });
 
             dataSource.query({ sort: { field: "foo", dir: "asc" } });
-            assert.isOk($.isArray(dataSource.sort()));
+            assert.isOk(Array.isArray(dataSource.sort()));
             assert.equal(dataSource.sort()[0].field, "foo");
             assert.equal(dataSource.sort()[0].dir, "asc");
 
@@ -1391,7 +1391,7 @@
             });
 
             dataSource.query({ filter: { field: "age", operator: "==", value: 2 } });
-            assert.isOk($.isArray(dataSource.filter().filters));
+            assert.isOk(Array.isArray(dataSource.filter().filters));
             assert.equal(dataSource.filter().filters[0].field, "age");
             assert.equal(dataSource.filter().filters[0].operator, "eq");
             assert.equal(dataSource.filter().filters[0].value, 2);
@@ -2335,7 +2335,7 @@
                 serverSorting: true
             });
 
-            assert.isOk($.isFunction(dataSource.query().then));
+            assert.isOk(kendo.isFunction(dataSource.query().then));
         });
 
         it("query returns promise for local operations", function() {
@@ -2347,7 +2347,7 @@
 
             dataSource.read();
 
-            assert.isOk($.isFunction(dataSource.query().then));
+            assert.isOk(kendo.isFunction(dataSource.query().then));
         });
 
         it("query resolves promise after data has been processed", function() {

tests/data/datasource/query.js

@@ -751,7 +751,7 @@
                 }
             });
 
-            assert.isOk($.isFunction(dataSource.read().then));
+            assert.isOk(kendo.isFunction(dataSource.read().then));
         });
 
         it("read resolves promise upon success", function() {

tests/data/datasource/read.js

@@ -19,7 +19,7 @@
         var obj = {};
         data = data !== undefined ? data : [{ id: 1, foo: "bar" }];
         obj[method] = function(options) {
-            options.success($.isFunction(data) ? data() : data);
+            options.success(kendo.isFunction(data) ? data() : data);
         };
 
         stub(dataSource.transport, obj);

tests/data/datasource/sync-response.js

@@ -284,7 +284,7 @@
 
             var models = dataSource.transport.args("create")[0].data.models;
 
-            assert.isOk($.isArray(models));
+            assert.isOk(Array.isArray(models));
             assert.equal(models.length, 2);
             assert.equal(models[0].foo, "foo");
             assert.equal(models[1].foo, "bar");
@@ -329,7 +329,7 @@
             dataSource.sync();
 
             var models = dataSource.transport.args("update")[0].data.models;
-            assert.isOk($.isArray(models));
+            assert.isOk(Array.isArray(models));
             assert.equal(models.length, 2);
             assert.equal(models[0].foo, "foo");
             assert.equal(models[1].foo, "bar");
@@ -371,7 +371,7 @@
 
 
             var models = dataSource.transport.args("destroy")[0].data.models;
-            assert.isOk($.isArray(models));
+            assert.isOk(Array.isArray(models));
             assert.equal(models.length, 2);
             assert.equal(models[0].id, 1);
             assert.equal(models[1].id, 2);
@@ -864,7 +864,7 @@
 
             var promise = dataSource.sync();
 
-            assert.isOk($.isFunction(promise.then));
+            assert.isOk(kendo.isFunction(promise.then));
         });
 
         it("sync returns promise when offline", function() {
@@ -881,7 +881,7 @@
 
             var promise = dataSource.sync();
 
-            assert.isOk($.isFunction(promise.then));
+            assert.isOk(kendo.isFunction(promise.then));
 
             promise.then($.proxy(assert.isOk, this, true));
 

tests/data/datasource/sync.js

@@ -1205,7 +1205,7 @@
 
             dataSource.read();
 
-            assert.isOk($.isFunction(dataSource.get(1).load().then));
+            assert.isOk(kendo.isFunction(dataSource.get(1).load().then));
         });
 
         it("Node without children resolves load promise immediately", function() {