Skip to content

Conversation

@mslxl
Copy link

@mslxl mslxl commented Oct 31, 2025

In the original code, the way to ensure NDK installation is to check whether the ndk folder exists under the $ANDROID_HOME directory. If it exists, the NDK_HOME environment variable is set; otherwise, the NDK will be installed. This approach overrides any user-set NDK_HOME variable. However, on some systems (like NixOS), the NDK installed via package managers may not be located in the $ANDROID_HOME/ndk directory but elsewhere. Ignoring the NDK_HOME variable would render such system-installed NDKs unusable.

This PR bypasses the NDK check when NDK_HOME has already been set.

@mslxl mslxl requested a review from a team as a code owner October 31, 2025 13:04
@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap Oct 31, 2025
@github-actions
Copy link
Contributor

Package Changes Through fcc5fc5

No changes.

Add a change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📬Proposal

Development

Successfully merging this pull request may close these issues.

1 participant