wrap_* macros are not good DX

[amrbashir]

There is a few issues with the current wrap_* macros that ruin DX and actively makes me want to punch my monitor:

1. Can't be formatted with cargo fmt or rustfmt

2. No IDE IntelliSense support for trait methods

   wrap_keyboard_handler! {
       struct DemoKeyboardHandler {}
   
       impl KeyboardHandler {
         // press ctrl+space here, doesn't show any methods
       }
   }

3. Need to know class hierarchy and order of implementation, otherwise, you get "Unexpected token in input":

   wrap_window_delegate! {
       struct DemoWindowDelegate {}
   
       impl ViewDelegate {}
   
       impl PanelDelegate {}
   
       impl WindowDelegate {}
   }

   if you impl PanelDelegate before ViewDelegate, you get error.
   if you forget to impl ViewDelegate you get error.

   More than often, I have to open wrap_* macro definition to know what I am missing or the shape of a method I want to implement.

[wravery]

A lot of these could possibly be fixed by replacing the macro_rules! implementation with derive macros, but AFAIK that would require a separate proc-macro lib crate with the macro definitions.

One workaround that I've found for rustfmt is to temporarily replace the macro call with a module declaration of the same name, run rustfmt, then put it back:

// Run rustfmt, then change this back to the macro call.
mod wrap_keyboard_handler {
    struct DemoKeyboardHandler {}

    impl KeyboardHandler {
      // press ctrl+space here, doesn't show any methods
    }
}

It doesn't build or pass cargo check, but it's a valid AST that rustfmt can handle.

[amrbashir]

A lot of these could possibly be fixed by replacing the macro_rules! implementation with derive macros, but AFAIK that would require a separate proc-macro lib crate with the macro definitions.

I figured as much, in terms of DX, it is better but probably much much worse compile times, but taking that windows-rs has implement proc-macro, I think it should be fine.

One workaround that I've found for rustfmt is to temporarily replace the macro call with a module declaration of the same name, run rustfmt, then put it back:

// Run rustfmt, then change this back to the macro call.
mod wrap_keyboard_handler {
struct DemoKeyboardHandler {}

impl KeyboardHandler {
  // press ctrl+space here, doesn't show any methods
}

}

It doesn't build or pass cargo check, but it's a valid AST that rustfmt can handle.

Still bad DX though 😄