-
Notifications
You must be signed in to change notification settings - Fork 40
Open
Labels
featureA new functionalityA new functionality
Description
Lines 717 to 720 in da78c01
local r = self:match(request.method, request.path) | |
if r == nil then | |
return static_file(self, request, format) | |
end |
Static_file dir should a part of route.
httpd:route(
{path = "/*slug", public = true, name = "default"},
http_middleware.v1(handle_get_default, http_collector)
)
Currently it is not possible to have "default" http endpoint and static content path at the same time. As "default" overlap "static_file".
I'd like to have default http route to match "unspecified" routes, to log it and return specific/custom response (json, etc.). Currently it is not possible because it iterates/bruteforces:
- through
httpd.routes
; - if nothing found from 1., it takes it as "static" content, if found returns funct;
- and finnaly returns 404 -
Line 611 in da78c01
return { status = 404 }
I suggest "static" directory path should be registered/added to httpd.routes
as well.
Metadata
Metadata
Assignees
Labels
featureA new functionalityA new functionality