Skip to content

Cannt add "default" http route. Static_file dir should a part of routes #172

@eugenepaniot

Description

@eugenepaniot

http/http/server.lua

Lines 717 to 720 in da78c01

local r = self:match(request.method, request.path)
if r == nil then
return static_file(self, request, format)
end

Static_file dir should a part of route.

httpd:route(
            {path = "/*slug", public = true, name = "default"},
            http_middleware.v1(handle_get_default, http_collector)
        )

Currently it is not possible to have "default" http endpoint and static content path at the same time. As "default" overlap "static_file".

I'd like to have default http route to match "unspecified" routes, to log it and return specific/custom response (json, etc.). Currently it is not possible because it iterates/bruteforces:

  1. through httpd.routes ;
  2. if nothing found from 1., it takes it as "static" content, if found returns funct;
  3. and finnaly returns 404 -
    return { status = 404 }

I suggest "static" directory path should be registered/added to httpd.routes as well.

Metadata

Metadata

Assignees

No one assigned

    Labels

    featureA new functionality

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions