Skip to content

Commit e902d59

Browse files
authored
Fixed undefined constant error when using PantherTestCaseTrait (#439)
* Introduced a new enum containing browser names * Update Browser.php * Referenced PantherTestCase::CHROME instead of static::CHROME * Referenced PantherTestCase::CHROME instead of static::CHROME * Fixed use of constant
1 parent fa8885c commit e902d59

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/PantherTestCaseTrait.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,13 +164,13 @@ public function takeScreenshotIfTestFailed(): void
164164
*/
165165
protected static function createPantherClient(array $options = [], array $kernelOptions = [], array $managerOptions = []): PantherClient
166166
{
167-
$browser = ($options['browser'] ?? self::$defaultOptions['browser'] ?? static::CHROME);
167+
$browser = ($options['browser'] ?? self::$defaultOptions['browser'] ?? PantherTestCase::CHROME);
168168
$callGetClient = \is_callable([self::class, 'getClient']) && (new \ReflectionMethod(self::class, 'getClient'))->isStatic();
169169
if (null !== self::$pantherClient) {
170170
$browserManager = self::$pantherClient->getBrowserManager();
171171
if (
172-
(static::CHROME === $browser && $browserManager instanceof ChromeManager) ||
173-
(static::FIREFOX === $browser && $browserManager instanceof FirefoxManager)
172+
(PantherTestCase::CHROME === $browser && $browserManager instanceof ChromeManager) ||
173+
(PantherTestCase::FIREFOX === $browser && $browserManager instanceof FirefoxManager)
174174
) {
175175
ServerExtension::registerClient(self::$pantherClient);
176176

@@ -180,7 +180,7 @@ protected static function createPantherClient(array $options = [], array $kernel
180180

181181
self::startWebServer($options);
182182

183-
if (static::CHROME === $browser) {
183+
if (PantherTestCase::CHROME === $browser) {
184184
self::$pantherClients[0] = self::$pantherClient = Client::createChromeClient(null, null, $managerOptions, self::$baseUri);
185185
} else {
186186
self::$pantherClients[0] = self::$pantherClient = Client::createFirefoxClient(null, null, $managerOptions, self::$baseUri);

0 commit comments

Comments
 (0)