ci: fixed static analysis (#655)

Author: yohang

phpstan.neon

@@ -13,6 +13,12 @@ parameters:
 	ignoreErrors:
 		# False positive
 		- '#Call to an undefined method ReflectionType::getName\(\)\.#'
+		# False positive : assertNotEmpty assert that count() !== 0 on Countable
+		- '#Call to static method PHPUnit\\Framework\\Assert::assert(Not)?Empty\(\) with Symfony\\Component\\DomCrawler\\Crawler will always evaluate to (true|false)\.#'
+		# False positive : getStatus exists for PHPUnit < 10 only
+		- '#Call to function method_exists\(\) with \$this\(Symfony\\Component\\Panther\\PantherTestCase\) and ''getStatus'' will always evaluate to true\.#'
+		# False positive : PantherTestCase has no getClient method when symfony/framework-bundle (and WebTestCase) are not available
+		- '#Call to function method_exists\(\) with ''Symfony\\\\Component\\\\Panther\\\\PantherTestCase'' and ''getClient'' will always evaluate to true\.#'
 		# To fix in PHP WebDriver
 		- '#Parameter \#2 \$desired_capabilities of static method Facebook\\WebDriver\\Remote\\RemoteWebDriver::create\(\) expects array\|Facebook\\WebDriver\\Remote\\DesiredCapabilities\|null, Facebook\\WebDriver\\WebDriverCapabilities given\.#'
 		# Require a redesign of the underlying Symfony components

src/DomCrawler/Form.php

@@ -211,10 +211,7 @@ public function set(FormField $field): void
         $this->setValue($field->getName(), $field->getValue());
     }
 
-    /**
-     * @return FormField|FormField[]|FormField[][]
-     */
-    public function get($name): FormField|array
+    public function get($name): FormField
     {
         return $this->getFormField($this->getFormElement($name));
     }
@@ -238,10 +235,8 @@ public function offsetExists($name): bool
      * Gets the value of a field.
      *
      * @param string $name
-     *
-     * @return FormField|FormField[]|FormField[][]
      */
-    public function offsetGet($name): FormField|array
+    public function offsetGet($name): FormField
     {
         return $this->get($name);
     }

src/WebTestAssertionsTrait.php

@@ -39,8 +39,9 @@ public static function assertSelectorExists(string $selector, string $message =
         $client = self::getClient();
 
         if ($client instanceof PantherClient) {
-            $element = self::findElement($selector);
-            self::assertNotNull($element, $message);
+            $by = $client::createWebDriverByFromLocator($selector);
+            $elements = $client->findElements($by);
+            self::assertNotEmpty($elements, $message);
 
             return;
         }
@@ -92,12 +93,6 @@ public static function assertPageTitleContains(string $expectedTitle, string $me
     {
         $client = self::getClient();
         if ($client instanceof PantherClient) {
-            if (method_exists(self::class, 'assertStringContainsString')) {
-                self::assertStringContainsString($expectedTitle, $client->getTitle());
-
-                return;
-            }
-
             self::assertStringContainsString($expectedTitle, $client->getTitle());
 
             return;

tests/DomCrawler/CrawlerTest.php

@@ -288,9 +288,6 @@ public function testParents(callable $clientFactory): void
     public function testAncestors(callable $clientFactory): void
     {
         $crawler = $this->request($clientFactory, '/basic.html');
-        if (!method_exists($crawler, 'ancestors')) {
-            $this->markTestSkipped('Crawler::ancestors() doesn\'t exist.');
-        }
 
         $names = [];
         $crawler->filter('main > h1')->ancestors()->each(function (Crawler $c, int $i) use (&$names) {

tests/ScreenshotTest.php

@@ -37,7 +37,7 @@ public function testTakeScreenshot(): void
 
         $screen = $client->takeScreenshot();
 
-        $this->assertIsString($screen);
+        $this->assertNotEmpty($screen);
     }
 
     public function testTakeScreenshotAndSaveToFile(): void