[HttpFoundation][HttpKernel] Remove dead code and useless casts

Author: alexandre-daubois

BinaryFileResponse.php

@@ -70,7 +70,7 @@ public function setFile(\SplFileInfo|string $file, ?string $contentDisposition =
             if ($file instanceof \SplFileInfo) {
                 $file = new File($file->getPathname(), !$isTemporaryFile);
             } else {
-                $file = new File((string) $file);
+                $file = new File($file);
             }
         }
 

File/File.php

@@ -134,8 +134,7 @@ protected function getName(string $name): string
     {
         $originalName = str_replace('\\', '/', $name);
         $pos = strrpos($originalName, '/');
-        $originalName = false === $pos ? $originalName : substr($originalName, $pos + 1);
 
-        return $originalName;
+        return false === $pos ? $originalName : substr($originalName, $pos + 1);
     }
 }

HeaderBag.php

@@ -118,7 +118,7 @@ public function get(string $key, ?string $default = null): ?string
             return null;
         }
 
-        return (string) $headers[0];
+        return $headers[0];
     }
 
     /**

Request.php

@@ -1878,7 +1878,7 @@ protected function preparePathInfo(): string
         }
 
         $pathInfo = substr($requestUri, \strlen($baseUrl));
-        if (false === $pathInfo || '' === $pathInfo) {
+        if ('' === $pathInfo) {
             // If substr() returns false then PATH_INFO is set to an empty string
             return '/';
         }

Test/Constraint/ResponseCookieValueSame.php

@@ -34,9 +34,8 @@ public function toString(): string
         if ($this->domain) {
             $str .= \sprintf(' for domain "%s"', $this->domain);
         }
-        $str .= \sprintf(' with value "%s"', $this->value);
 
-        return $str;
+        return $str.\sprintf(' with value "%s"', $this->value);
     }
 
     /**