Skip to content

Commit 5661c41

Browse files
committed
minor #29398 [FrameworkBundle][Controller] Use interface from Contracts to remove deprecation arnings (tomtomau)
This PR was merged into the 4.2 branch. Discussion ---------- [FrameworkBundle][Controller] Use interface from Contracts to remove deprecation arnings | Q | A | ------------- | --- | Branch? | 4.2? | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | I don't think so <!-- see https://symfony.com/bc --> | Deprecations? | no - removing some :) <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | n/a When we installed 4.2, we hit issues in our qa tools with [vimeo/psalm](https://github.com/vimeo/psalm) reporting that all of our controllers were implementing a deprecated interface (by extending the AbstractController). This pr simply updates the AbstractController to use the interface provided in `symfony/contracts` I'm not sure if there was any other reason for not including this in the 4.2 release (bc?), so apologies if I've overstepped this. Commits ------- f10227df3d [FrameworkBundle][Controller] Use interface from Contracts to remove deprecation warnings
2 parents eb32d67 + 7d68535 commit 5661c41

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Controller/AbstractController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
use Psr\Container\ContainerInterface;
1616
use Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException;
1717
use Symfony\Component\DependencyInjection\ParameterBag\ContainerBagInterface;
18-
use Symfony\Component\DependencyInjection\ServiceSubscriberInterface;
1918
use Symfony\Component\Form\FormFactoryInterface;
2019
use Symfony\Component\HttpFoundation\RequestStack;
2120
use Symfony\Component\HttpFoundation\Session\SessionInterface;
@@ -27,6 +26,7 @@
2726
use Symfony\Component\Security\Csrf\CsrfTokenManagerInterface;
2827
use Symfony\Component\Serializer\SerializerInterface;
2928
use Symfony\Component\Templating\EngineInterface;
29+
use Symfony\Contracts\Service\ServiceSubscriberInterface;
3030
use Twig\Environment;
3131

3232
/**

0 commit comments

Comments
 (0)