Skip to content

Commit f96b8bf

Browse files
committed
bug #1005 fix(recipes:update): github api now requires is:pull-request parameter (alainsharemat)
This PR was submitted for the 2.x branch but it was squashed and merged into the 1.x branch instead. Discussion ---------- fix(recipes:update): github api now requires is:pull-request parameter This fix is related to issue #974. While running `recipes:update` I got this error: ```shell Calculating CHANGELOG... In CurlDownloader.php line 630: The "https://api.github.com/search/issues?q=95e75e5e424c5f5f611cc57073e399baaf287570" file could not be downloaded (HTTP/2 422 ): {"message":"Query must include 'is:issue' or 'is:pull-request'","documentation_url":"https://docs.github.com/rest/search/search#search-issues-and-pull-requests"} ``` According to github's [documentation](https://docs.github.com/en/rest/search/search?apiVersion=2022-11-28#search-issues-and-pull-requests) : `Requests that don't include the is:issue or is:pull-request qualifier will receive an HTTP 422 Unprocessable Entity response`. Commits ------- bc89553 fix(recipes:update): github api now requires is:pull-request parameter
2 parents f1cf401 + bc89553 commit f96b8bf

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/GithubApi.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public function getCommitDataForPath(string $repo, string $path, string $branch)
128128

129129
public function getPullRequestForCommit(string $commit, string $repo): ?array
130130
{
131-
$data = $this->requestGitHubApi('https://api.github.com/search/issues?q='.$commit);
131+
$data = $this->requestGitHubApi('https://api.github.com/search/issues?q='.$commit.'+is:pull-request');
132132

133133
if (0 === \count($data['items'])) {
134134
return null;

0 commit comments

Comments
 (0)