Because PHP 8.4 is adding deprecation warnings for non-nullable parameters with null default, change typehints

sam-bee · sam-bee · commit 6d8fc879230e · 2024-05-13T12:43:33.000+01:00
diff --git a/HttpClient/Test/TestHttpServer.php b/HttpClient/Test/TestHttpServer.php
@@ -21,7 +21,7 @@ class TestHttpServer
     /**
      * @param string|null $workingDirectory
      */
-    public static function start(int $port = 8057/* , string $workingDirectory = null */): Process
+    public static function start(int $port = 8057/* , ?string $workingDirectory = null */): Process
     {
         $workingDirectory = \func_get_args()[1] ?? __DIR__.'/Fixtures/web';
 

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class TestHttpServer`
`21`	`21`	`/**`
`22`	`22`	`* @param string\|null $workingDirectory`
`23`	`23`	`*/`
`24`		`- public static function start(int $port = 8057/* , string $workingDirectory = null */): Process`
	`24`	`+ public static function start(int $port = 8057/* , ?string $workingDirectory = null */): Process`
`25`	`25`	`{`
`26`	`26`	`$workingDirectory = \func_get_args()[1] ?? __DIR__.'/Fixtures/web';`
`27`	`27`