chore: Migrate to ESLint. (signalstickers#222)

* chore: Migrate to ESLint.

* Fix missing space after line

Co-authored-by: Romain Ricard <[email protected]>

Author: darkobits

.eslintrc.js

@@ -0,0 +1,8 @@
+module.exports = {
+  extends: [
+    require.resolve('@darkobits/ts-unified/dist/config/eslint-react')
+  ],
+  rules: {
+    'no-console': 'off'
+  }
+};

babel.config.js

@@ -1,21 +1,9 @@
 module.exports = {
+  extends: '@darkobits/ts-unified/dist/config/babel',
   presets: [
-    require.resolve('@babel/preset-env'),
-    require.resolve('@babel/preset-typescript'),
-    require.resolve('@babel/preset-react'),
     require.resolve('linaria/babel')
   ],
   plugins: [
-    require.resolve('react-hot-loader/babel'),
-    require.resolve('@babel/plugin-proposal-nullish-coalescing-operator'),
-    require.resolve('@babel/plugin-proposal-optional-chaining'),
-    require.resolve('@babel/plugin-proposal-class-properties'),
-    require.resolve('@babel/plugin-transform-runtime'),
-    [require.resolve('babel-plugin-module-resolver'), {
-      cwd: 'packagejson',
-      root: ['./src'],
-      extensions: ['.ts', '.tsx', '.js', '.jsx', '.json']
-    }]
-  ],
-  comments: false
+    'react-hot-loader/babel'
+  ]
 };

config/jest.config.js

@@ -1,29 +1,7 @@
 const path = require('path');
 
-
-const PKG_ROOT = path.resolve(__dirname, '..');
-
-
-const EXTENSIONS = ['ts', 'tsx', 'js', 'jsx', 'node'];
-
-const ALWAYS_IGNORE = [
-  `${PKG_ROOT}/dist`,
-  '/node_modules/'
-];
-
-
-module.exports = {
-  rootDir: PKG_ROOT,
-  testEnvironment: 'node',
-  testRegex: '^.+\\.spec.*$',
-  testPathIgnorePatterns: ALWAYS_IGNORE,
-  coveragePathIgnorePatterns: ALWAYS_IGNORE,
-  moduleFileExtensions: [...EXTENSIONS, 'json'],
-  collectCoverageFrom: [
-    `${PKG_ROOT}/src/**/*.{${EXTENSIONS.join(',')}}`,
-    `${PKG_ROOT}/tests/**/*.{${EXTENSIONS.join(',')}}`,
-    '!**/node_modules/**',
-  ],
+module.exports = require('@darkobits/ts-unified/dist/config/jest')({
+  rootDir: path.resolve(__dirname, '..'),
   clearMocks: true,
   coverageThreshold: {
     global: {
@@ -33,4 +11,4 @@ module.exports = {
       lines: 100
     }
   }
-};
+});

config/webpack.config.ts renamed to config/webpack.config.babel.ts

@@ -1,6 +1,7 @@
 import path from 'path';
 
 import FetchStickerDataPlugin from '@signalstickers/fetch-sticker-data-webpack-plugin';
+import {CleanWebpackPlugin} from 'clean-webpack-plugin';
 import CopyWebpackPlugin from 'copy-webpack-plugin';
 // @ts-ignore (No type definitions exist for this package.)
 import FaviconsWebpackPlugin from 'favicons-webpack-plugin';
@@ -41,23 +42,20 @@ export default (env: string, argv: any): webpack.Configuration => {
 
   // ----- Loaders -------------------------------------------------------------
 
-  // TSLint (Development only).
-  if (argv.mode === 'development') {
-    config.module.rules.push({
-      test: /\.(ts|tsx)$/,
-      exclude: /node_modules/,
-      enforce: 'pre',
-      use: [{
-        loader: 'tslint-loader',
-        options: {
-          configFile: path.resolve(PKG_ROOT, 'tslint.json'),
-          tsConfigFile: path.resolve(PKG_ROOT, 'tsconfig.json'),
-          formatter: 'codeFrame',
-          typeCheck: true
-        }
-      }]
-    });
-  }
+  // ESLint
+  config.module.rules.push({
+    test: /\.(ts|tsx)$/,
+    exclude: /node_modules/,
+    enforce: 'pre',
+    use: [{
+      loader: 'eslint-loader',
+      options: {
+        emitErrors: true,
+        emitWarning: true,
+        failOnError: argv.mode === 'production'
+      }
+    }]
+  });
 
   // TypeScript & JavaScript files.
   config.module.rules.push({
@@ -164,27 +162,31 @@ export default (env: string, argv: any): webpack.Configuration => {
     config.plugins.push(new FriendlyErrorsWebpackPlugin());
 
     config.plugins.push(new MiniCssExtractPlugin({
-      filename: 'styles.css',
+      filename: 'styles.css'
     }));
   }
 
   if (argv.mode === 'production') {
-    config.plugins.push(new CopyWebpackPlugin([{
-      // When performing a production build, instruct Webpack to copy all files
-      // in the 'static' directory into the build directory.
-      from: path.resolve(PKG_ROOT, 'static'),
-      to: path.resolve(PKG_ROOT, 'dist')
-    }]));
+    // Delete the build output directory before production builds.
+    config.plugins.push(new CleanWebpackPlugin());
+
+    config.plugins.push(new CopyWebpackPlugin({
+      patterns: [{
+        // When performing a production build, instruct Webpack to copy all
+        // files in the 'static' directory into the build directory.
+        from: path.resolve(PKG_ROOT, 'static'),
+        to: path.resolve(PKG_ROOT, 'dist')
+      }]
+    }));
 
     config.plugins.push(new MiniCssExtractPlugin({
-      filename: 'styles-[contenthash].css',
+      filename: 'styles-[contenthash].css'
     }));
 
     config.plugins.push(new webpack.LoaderOptionsPlugin({
       minimize: true
     }));
 
-
     config.plugins.push(new FaviconsWebpackPlugin({
       logo: path.resolve(PKG_ROOT, 'src', 'assets', 'favicon.png'),
       cache: true,
@@ -195,7 +197,7 @@ export default (env: string, argv: any): webpack.Configuration => {
         appDescription: '',
         version: '',
         developerName: '',
-        developerURL: '',
+        developerURL: ''
       }
     }));
   }