perf(es/utils): Prevent too many recursion (#9931)

**Description:**


![image](https://github.com/user-attachments/assets/40841d3a-9fbf-41b5-98dd-45320d2e5261)

Some functions may recurse too much and have a bad effect on the performance.

Author: kdy1

.changeset/tall-tigers-explain.md

@@ -0,0 +1,6 @@
+---
+swc_ecma_ast: patch
+swc_ecma_utils: major
+---
+
+perf(es/utils): Prevent too many recursion

crates/swc/tests/tsc-references/destructuringArrayBindingPatternAndAssignment3.2.minified.js

@@ -1,10 +1,10 @@
 //// [destructuringArrayBindingPatternAndAssignment3.ts]
-var _param, _param1, _param2;
 import { _ as _sliced_to_array } from "@swc/helpers/_/_sliced_to_array";
+var _param, _param1, tmp1, e, _param2, tmp2 = void 0, e1 = void 0 === tmp2 ? e1 : tmp2;
 (_param = _sliced_to_array([
     1
 ], 2))[0], _param[1], (_param1 = _sliced_to_array([
     1
-], 3))[0], _param1[1], _param1[2], (_param2 = _sliced_to_array([
+], 3))[0], _param1[1], e = void 0 === (tmp1 = _param1[2]) ? e : tmp1, (_param2 = _sliced_to_array([
     1
 ], 4))[0], _param2[1], _param2[2], _param2[3];

crates/swc/tests/tsc-references/destructuringObjectBindingPatternAndAssignment4.2.minified.js

@@ -1,3 +1,2 @@
 //// [destructuringObjectBindingPatternAndAssignment4.ts]
-var _ref = {};
-_ref.a, _ref.b, _ref.c, _ref.d, _ref.e, _ref.f;
+var _ref = {}, _ref_f = (_ref.a, _ref.b, _ref.c, _ref.d, _ref.e, _ref.f), f = void 0 === _ref_f ? f : _ref_f;

crates/swc/tests/tsc-references/destructuringVariableDeclaration1ES5.2.minified.js

@@ -11,16 +11,14 @@ var _ref2 = [
     void 0,
     void 0,
     void 0
-];
-_ref2[0], _ref2[1], _ref2[2];
-var _concat = _sliced_to_array([
+], _concat = (_ref2[0], _ref2[1], _ref2[2], _sliced_to_array([
     1,
     "string"
 ].concat(_to_consumable_array([
     !0,
     !1,
     !0
-])), 2);
+])), 2));
 _concat[0], _concat[1];
 var _ref_e = _sliced_to_array([
     1,
@@ -29,14 +27,12 @@ var _ref_e = _sliced_to_array([
         b1: 4,
         b4: 0
     }
-], 3);
-_ref_e[0], _ref_e[1], _ref_e[2];
-var _ref_f = _sliced_to_array([
+], 3), _ref_f = (_ref_e[0], _ref_e[1], _ref_e[2], _sliced_to_array([
     1,
     2,
     {
         f3: 4,
         f5: 0
     }
-], 3), _ref_f_ = (_ref_f[0], _ref_f[1], _ref_f[2]);
+], 3)), _ref_f_ = (_ref_f[0], _ref_f[1], _ref_f[2]);
 _ref_f_.f3, _ref_f_.f5;

crates/swc/tests/tsc-references/destructuringVariableDeclaration1ES5iterable.2.minified.js

@@ -11,16 +11,14 @@ var _ref2 = [
     void 0,
     void 0,
     void 0
-];
-_ref2[0], _ref2[1], _ref2[2];
-var _concat = _sliced_to_array([
+], _concat = (_ref2[0], _ref2[1], _ref2[2], _sliced_to_array([
     1,
     "string"
 ].concat(_to_consumable_array([
     !0,
     !1,
     !0
-])), 2);
+])), 2));
 _concat[0], _concat[1];
 var _ref_e = _sliced_to_array([
     1,
@@ -29,14 +27,12 @@ var _ref_e = _sliced_to_array([
         b1: 4,
         b4: 0
     }
-], 3);
-_ref_e[0], _ref_e[1], _ref_e[2];
-var _ref_f = _sliced_to_array([
+], 3), _ref_f = (_ref_e[0], _ref_e[1], _ref_e[2], _sliced_to_array([
     1,
     2,
     {
         f3: 4,
         f5: 0
     }
-], 3), _ref_f_ = (_ref_f[0], _ref_f[1], _ref_f[2]);
+], 3)), _ref_f_ = (_ref_f[0], _ref_f[1], _ref_f[2]);
 _ref_f_.f3, _ref_f_.f5;

crates/swc/tests/tsc-references/destructuringWithLiteralInitializers.2.minified.js

@@ -1,5 +1,5 @@
 //// [destructuringWithLiteralInitializers.ts]
-var param, param1, param2, param3, param4, param5, param6, _param, _param1;
+var param, _param, _param1, param1, param2, param3, param4, param5, param6;
 import { _ as _sliced_to_array } from "@swc/helpers/_/_sliced_to_array";
 function f4() {
     var _ref = arguments.length > 0 && void 0 !== arguments[0] ? arguments[0] : {

crates/swc/tests/tsc-references/privateNameStaticEmitHelpers.2.minified.js

@@ -1,7 +1,7 @@
 //// [privateNameStaticEmitHelpers.ts]
 //// [main.ts]
-import "@swc/helpers/_/_class_static_private_field_spec_set";
-import "@swc/helpers/_/_class_static_private_method_get";
+import { _ as _class_static_private_field_spec_set } from "@swc/helpers/_/_class_static_private_field_spec_set";
+import { _ as _class_static_private_method_get } from "@swc/helpers/_/_class_static_private_method_get";
 export class S {
 }
 //// [tslib.d.ts]

crates/swc_ecma_ast/src/expr.rs

@@ -200,9 +200,13 @@ impl Expr {
         }
     }
 
-    pub fn is_ident_ref_to(&self, ident: &str) -> bool {
+    pub fn is_ident_ref_to<S>(&self, ident: &S) -> bool
+    where
+        S: ?Sized,
+        Atom: PartialEq<S>,
+    {
         match self {
-            Expr::Ident(i) => i.sym == ident,
+            Expr::Ident(i) => i.sym == *ident,
             _ => false,
         }
     }

crates/swc_ecma_minifier/src/compress/optimize/bools.rs

@@ -22,7 +22,7 @@ impl Optimizer<'_> {
         is_ret_val_ignored: bool,
     ) -> bool {
         let cost = negate_cost(
-            &self.ctx.expr_ctx,
+            self.ctx.expr_ctx,
             expr,
             is_ret_val_ignored,
             is_ret_val_ignored,

crates/swc_ecma_minifier/src/compress/optimize/conditionals.rs

@@ -30,7 +30,7 @@ impl Optimizer<'_> {
             _ => {}
         }
 
-        if negate_cost(&self.ctx.expr_ctx, &stmt.test, true, false) < 0 {
+        if negate_cost(self.ctx.expr_ctx, &stmt.test, true, false) < 0 {
             report_change!("if_return: Negating `cond` of an if statement which has cons and alt");
             let ctx = Ctx {
                 in_bool_ctx: true,
@@ -63,7 +63,7 @@ impl Optimizer<'_> {
             _ => return,
         };
 
-        if !cond.cons.may_have_side_effects(&self.ctx.expr_ctx) {
+        if !cond.cons.may_have_side_effects(self.ctx.expr_ctx) {
             self.changed = true;
             report_change!("conditionals: `cond ? useless : alt` => `cond || alt`");
             *e = BinExpr {
@@ -76,7 +76,7 @@ impl Optimizer<'_> {
             return;
         }
 
-        if !cond.alt.may_have_side_effects(&self.ctx.expr_ctx) {
+        if !cond.alt.may_have_side_effects(self.ctx.expr_ctx) {
             self.changed = true;
             report_change!("conditionals: `cond ? cons : useless` => `cond && cons`");
             *e = BinExpr {
@@ -880,7 +880,7 @@ impl Optimizer<'_> {
                         ) = (&*cons, &*alt)
                         {
                             // I don't know why, but terser behaves differently
-                            negate(&self.ctx.expr_ctx, &mut test, true, false);
+                            negate(self.ctx.expr_ctx, &mut test, true, false);
 
                             swap(&mut cons, &mut alt);
                         }