chore: add test for parsing body size limit (#13437)

* node-adapter: add test for parsing body size limit

* slight adjustments

---------

Co-authored-by: Chew Tee Ming <[email protected]>

Author: alexfu

eslint.config.js

@@ -27,11 +27,11 @@ export default [
 			'@typescript-eslint/await-thenable': 'error',
 			'@typescript-eslint/no-unused-expressions': 'off',
 			'@typescript-eslint/require-await': 'error',
-			'@typescript-eslint/no-floating-promises': 'error',
+			'@typescript-eslint/no-floating-promises': 'error'
 		},
 		ignores: [
 			'packages/adapter-node/rollup.config.js',
-			'packages/adapter-node/tests/smoke.spec.js',
+			'packages/adapter-node/tests/smoke.spec_disabled.js',
 			'packages/adapter-static/test/apps/**/*',
 			'packages/create-svelte/shared/**/*',
 			'packages/create-svelte/templates/**/*',

packages/adapter-node/package.json

@@ -35,7 +35,7 @@
 	"scripts": {
 		"dev": "node -e \"fs.rmSync('files', { force: true, recursive: true })\" && rollup -cw",
 		"build": "node -e \"fs.rmSync('files', { force: true, recursive: true })\" && rollup -c",
-		"test": "echo \"tests temporarily disabled\" # vitest run",
+		"test": "vitest run",
 		"check": "tsc",
 		"lint": "prettier --check .",
 		"format": "pnpm lint --write",

packages/adapter-node/src/handler.js

@@ -9,6 +9,7 @@ import { getRequest, setResponse, createReadableStream } from '@sveltejs/kit/nod
 import { Server } from 'SERVER';
 import { manifest, prerendered, base } from 'MANIFEST';
 import { env } from 'ENV';
+import { parse_as_bytes } from '../utils.js';
 
 /* global ENV_PREFIX */
 
@@ -21,20 +22,7 @@ const protocol_header = env('PROTOCOL_HEADER', '').toLowerCase();
 const host_header = env('HOST_HEADER', 'host').toLowerCase();
 const port_header = env('PORT_HEADER', '').toLowerCase();
 
-/**
- * @param {string} bytes
- */
-function parse_body_size_limit(bytes) {
-	const multiplier =
-		{
-			K: 1024,
-			M: 1024 * 1024,
-			G: 1024 * 1024 * 1024
-		}[bytes[bytes.length - 1]?.toUpperCase()] ?? 1;
-	return Number(multiplier != 1 ? bytes.substring(0, bytes.length - 1) : bytes) * multiplier;
-}
-
-const body_size_limit = parse_body_size_limit(env('BODY_SIZE_LIMIT', '512K'));
+const body_size_limit = parse_as_bytes(env('BODY_SIZE_LIMIT', '512K'));
 
 if (isNaN(body_size_limit)) {
 	throw new Error(

packages/adapter-node/tests/smoke.spec.js renamed to packages/adapter-node/tests/smoke.spec_disabled.js

@@ -0,0 +1,21 @@
+import { expect, test, describe } from 'vitest';
+import { parse_as_bytes } from '../utils.js';
+
+describe('parse_as_bytes', () => {
+	test('parses correctly', () => {
+		const testData = {
+			200: 200,
+			'512K': 512 * 1024,
+			'200M': 200 * 1024 * 1024,
+			'1G': 1024 * 1024 * 1024,
+			Infinity,
+			asdf: NaN
+		};
+
+		Object.keys(testData).forEach((input) => {
+			const expected = testData[/** @type {keyof typeof testData} */ (input)];
+			const actual = parse_as_bytes(input);
+			expect(actual, `Testing input '${input}'`).toBe(expected);
+		});
+	});
+});

packages/adapter-node/tests/utils.spec.js

@@ -13,5 +13,6 @@
 			"@sveltejs/kit": ["../kit/types/index"]
 		}
 	},
-	"include": ["index.js", "src/**/*.js", "internal.d.ts"]
+	"include": ["index.js", "src/**/*.js", "tests/**/*.js", "internal.d.ts", "utils.js"],
+	"exclude": ["tests/smoke.spec_disabled.js"]
 }

packages/adapter-node/tsconfig.json

@@ -0,0 +1,15 @@
+/**
+ * Parses the given value into number of bytes.
+ *
+ * @param {string} value - Size in bytes. Can also be specified with a unit suffix kilobytes (K), megabytes (M), or gigabytes (G).
+ * @returns {number}
+ */
+export function parse_as_bytes(value) {
+	const multiplier =
+		{
+			K: 1024,
+			M: 1024 * 1024,
+			G: 1024 * 1024 * 1024
+		}[value[value.length - 1]?.toUpperCase()] ?? 1;
+	return Number(multiplier != 1 ? value.substring(0, value.length - 1) : value) * multiplier;
+}