♻️(frontend) centralize allowed conversion formats in ContentTypes

Replace ContentTypes enum with a structured object mapping MIME types
to their file extensions, removing the manual switch-case in useImport

Signed-off-by: Stephan Meijer <me@stephanmeijer.com>

Author: StephanMeijer

src/frontend/apps/impress/src/features/docs/docs-grid/api/useImportDoc.tsx

@@ -17,12 +17,30 @@ import {
 } from '@/api';
 import { Doc, DocsResponse, KEY_LIST_DOC } from '@/docs/doc-management';
 
-export enum ContentTypes {
-  Docx = 'application/vnd.openxmlformats-officedocument.wordprocessingml.document',
-  Markdown = 'text/markdown',
-  OctetStream = 'application/octet-stream',
+interface ContentType {
+  mime: string;
+  extensions: string[];
 }
 
+export const ContentTypes: {
+  Docx: ContentType;
+  Markdown: ContentType;
+  OctetStream: ContentType;
+} = {
+  Docx: {
+    mime: 'application/vnd.openxmlformats-officedocument.wordprocessingml.document',
+    extensions: ['.docx'],
+  },
+  Markdown: {
+    mime: 'text/markdown',
+    extensions: ['.md', '.markdown'],
+  },
+  OctetStream: {
+    mime: 'application/octet-stream',
+    extensions: [],
+  },
+};
+
 export const importDoc = async ([file, mimeType]: [
   File,
   string,

src/frontend/apps/impress/src/features/docs/docs-grid/hooks/useImport.tsx

@@ -14,6 +14,10 @@ interface UseImportProps {
   onDragOver: (isDragOver: boolean) => void;
 }
 
+interface AcceptedMap {
+  [mime: string]: string[];
+}
+
 export const useImport = ({ onDragOver }: UseImportProps) => {
   const { toast } = useToastProvider();
   const { data: config } = useConfig();
@@ -36,31 +40,26 @@ export const useImport = ({ onDragOver }: UseImportProps) => {
     };
   }, [config?.CONVERSION_FILE_MAX_SIZE]);
 
-  const ACCEPT = useMemo(() => {
-    const extensions = config?.CONVERSION_FILE_EXTENSIONS_ALLOWED;
-    const accept: { [key: string]: string[] } = {};
-
-    if (extensions && extensions.length > 0) {
-      extensions.forEach((ext) => {
-        switch (ext.toLowerCase()) {
-          case '.docx':
-            accept[ContentTypes.Docx] = ['.docx'];
-            break;
-          case '.md':
-          case '.markdown':
-            accept[ContentTypes.Markdown] = ['.md'];
-            break;
-          default:
-            break;
+  const ACCEPT = useMemo((): AcceptedMap => {
+    const allowedExtensions = config?.CONVERSION_FILE_EXTENSIONS_ALLOWED?.map(
+      (ext: string) => ext.toLowerCase(),
+    ) ?? ['.docx', '.md'];
+
+    return Object.values(ContentTypes).reduce(
+      (acc: AcceptedMap, contentType) => {
+        const isAllowed = contentType.extensions.some((ext: string) =>
+          allowedExtensions.includes(ext),
+        );
+
+        if (isAllowed) {
+          acc[contentType.mime] = contentType.extensions;
         }
-      });
-    } else {
-      // Default to docx and md if no configuration is provided
-      accept[ContentTypes.Docx] = ['.docx'];
-      accept[ContentTypes.Markdown] = ['.md'];
-    }
 
-    return accept;
+        return acc;
+      },
+
+      {},
+    );
   }, [config?.CONVERSION_FILE_EXTENSIONS_ALLOWED]);
 
   const { getRootProps, getInputProps, open } = useDropzone({
@@ -96,11 +95,14 @@ export const useImport = ({ onDragOver }: UseImportProps) => {
             VariantType.ERROR,
           );
         } else {
+          const allowedExtensions = Object.values(ACCEPT).flat().join(', ');
+
           toast(
             t(
-              `The document "{{documentName}}" import has failed (only .docx and .md files are allowed)`,
+              `The document "{{documentName}}" import has failed (only {{allowedExtensions}} files are allowed)`,
               {
                 documentName: rejection.file.name,
+                allowedExtensions,
               },
             ),
             VariantType.ERROR,