Address a few clippy lints

Signed-off-by: Daniel Egger <[email protected]>

Author: therealprof

CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Poll for SPI transaction completion before returning
 - Update `remap_pins()` and remove critical section
 - Updated `stm32f0` peripheral access crate from 0.13 to 0.14
+- Address a few clippy lints
 
 ### Added
 

src/adc.rs

@@ -289,7 +289,7 @@ impl VTemp {
     /// Otherwise it will approximate the required delay using ADC reads.
     pub fn read(adc: &mut Adc, delay: Option<&mut Delay>) -> i16 {
         let mut vtemp = Self::new();
-        let vtemp_preenable = vtemp.is_enabled(&adc);
+        let vtemp_preenable = vtemp.is_enabled(adc);
 
         if !vtemp_preenable {
             vtemp.enable(adc);
@@ -345,7 +345,7 @@ impl VRef {
 
         let prev_cfg = adc.default_cfg();
 
-        let vref_val: u32 = if vref.is_enabled(&adc) {
+        let vref_val: u32 = if vref.is_enabled(adc) {
             adc.read(&mut vref).unwrap()
         } else {
             vref.enable(adc);
@@ -435,7 +435,7 @@ impl VBat {
     pub fn read(adc: &mut Adc) -> u16 {
         let mut vbat = Self::new();
 
-        let vbat_val: u16 = if vbat.is_enabled(&adc) {
+        let vbat_val: u16 = if vbat.is_enabled(adc) {
             adc.read_abs_mv(&mut vbat)
         } else {
             vbat.enable(adc);

src/i2c.rs

@@ -203,7 +203,7 @@ impl<I2C, SCLPIN, SDAPIN> I2c<I2C, SCLPIN, SDAPIN>
 where
     I2C: Deref<Target = I2cRegisterBlock>,
 {
-    fn i2c_init(self: Self, speed: KiloHertz) -> Self {
+    fn i2c_init(self, speed: KiloHertz) -> Self {
         use core::cmp;
 
         // Make sure the I2C unit is disabled so we can configure it

src/lib.rs

@@ -1,5 +1,6 @@
 #![no_std]
 #![allow(non_camel_case_types)]
+#![allow(clippy::uninit_assumed_init)]
 
 pub use stm32f0;
 

src/serial.rs

@@ -71,6 +71,7 @@ use crate::{gpio::*, rcc::Rcc, time::Bps};
 use core::marker::PhantomData;
 
 /// Serial error
+#[non_exhaustive]
 #[derive(Debug)]
 pub enum Error {
     /// Framing error
@@ -81,8 +82,6 @@ pub enum Error {
     Overrun,
     /// Parity check error
     Parity,
-    #[doc(hidden)]
-    _Extensible,
 }
 
 /// Interrupt event

src/spi.rs

@@ -74,6 +74,7 @@ pub struct EightBit;
 pub struct SixteenBit;
 
 /// SPI error
+#[non_exhaustive]
 #[derive(Debug)]
 pub enum Error {
     /// Overrun occurred
@@ -82,8 +83,6 @@ pub enum Error {
     ModeFault,
     /// CRC error
     Crc,
-    #[doc(hidden)]
-    _Extensible,
 }
 
 /// SPI abstraction
@@ -445,7 +444,7 @@ where
 
         for word in words.iter_mut() {
             nb::block!(self.check_send())?;
-            self.send_u8(word.clone());
+            self.send_u8(*word);
             nb::block!(self.check_read())?;
             *word = self.read_u8();
         }
@@ -522,7 +521,7 @@ where
 
         for word in words {
             nb::block!(self.check_send())?;
-            self.send_u16(word.clone());
+            self.send_u16(*word);
         }
 
         // Do one last status register check before continuing