Skip to content

Commit 7c29c2d

Browse files
committed
fix: use computed order
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 8722299 commit 7c29c2d

File tree

1 file changed

+4
-1
lines changed
  • lib/node_modules/@stdlib/ndarray/base/binary/lib

1 file changed

+4
-1
lines changed

lib/node_modules/@stdlib/ndarray/base/binary/lib/main.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
var iterationOrder = require( '@stdlib/ndarray/base/iteration-order' );
2424
var minmaxViewBufferIndex = require( '@stdlib/ndarray/base/minmax-view-buffer-index' );
2525
var ndarray2object = require( '@stdlib/ndarray/base/ndarraylike2object' );
26+
var strides2order = require( '@stdlib/ndarray/base/strides2order' );
2627
var format = require( '@stdlib/string/format' );
2728
var blockedaccessorbinary2d = require( './2d_blocked_accessors.js' );
2829
var blockedaccessorbinary3d = require( './3d_blocked_accessors.js' );
@@ -209,6 +210,7 @@ function binary( arrays, fcn ) { // eslint-disable-line max-statements
209210
var ioy;
210211
var ioz;
211212
var len;
213+
var ord;
212214
var sx;
213215
var sy;
214216
var sz;
@@ -297,7 +299,8 @@ function binary( arrays, fcn ) { // eslint-disable-line max-statements
297299
ioz = iterationOrder( sz ); // +/-1
298300

299301
// Determine whether we can avoid blocked iteration...
300-
if ( iox !== 0 && ioy !== 0 && ioz !== 0 && iox === ioy && ioy === ioz ) {
302+
ord = strides2order( sx );
303+
if ( iox !== 0 && ioy !== 0 && ioz !== 0 && ord === strides2order( sy ) && ord === strides2order( sz ) ) { // eslint-disable-line max-len
301304
// Determine the minimum and maximum linear indices which are accessible by the array views:
302305
xmmv = minmaxViewBufferIndex( shx, sx, x.offset );
303306
ymmv = minmaxViewBufferIndex( shy, sy, y.offset );

0 commit comments

Comments
 (0)