🪲: Failure building rust-s3

[stratacast]

What happened?

I had Dockerfile.fdb building successfully with stalwart v0.13.4 with #2275 and #2303, however, I am bumping into an issue building with v0.14.0 that I am working on.

I can build successfully with the regular Dockerfile, but I get failures with Dockerfile.fdb if I add building s3 to the features.

12.26 error[E0433]: failed to resolve: could not find `ServerCertVerified` in `client`                                                                                                                                                                        
12.26    --> /root/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rust-s3-0.35.1/src/request/tokio_backend.rs:75:28
12.26     |
12.26  75 |         Ok(rustls::client::ServerCertVerified::assertion())
12.26     |                            ^^^^^^^^^^^^^^^^^^ could not find `ServerCertVerified` in `client`
12.26     |
12.26 note: found an item that was configured out
12.26    --> /root/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustls-0.21.12/src/lib.rs:436:65
12.26     |
12.26 433 |     #[cfg(feature = "dangerous_configuration")]
12.26     |           ----------------------------------- the item is gated behind the `dangerous_configuration` feature
12.26 ...
12.26 436 |         CertificateTransparencyPolicy, HandshakeSignatureValid, ServerCertVerified,
12.26     |                                                                 ^^^^^^^^^^^^^^^^^^
12.26 
12.27 error[E0405]: cannot find trait `ServerCertVerifier` in module `rustls::client`
12.27    --> /root/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rust-s3-0.35.1/src/request/tokio_backend.rs:65:22
12.27     |
12.27  65 | impl rustls::client::ServerCertVerifier for NoCertificateVerification {
12.27     |                      ^^^^^^^^^^^^^^^^^^ not found in `rustls::client`
12.27     |
12.27 note: found an item that was configured out
12.27    --> /root/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustls-0.21.12/src/lib.rs:437:9
12.27     |
12.27 433 |     #[cfg(feature = "dangerous_configuration")]
12.27     |           ----------------------------------- the item is gated behind the `dangerous_configuration` feature
12.27 ...
12.27 437 |         ServerCertVerifier, WebPkiVerifier,
12.27     |         ^^^^^^^^^^^^^^^^^^
12.27 
12.27 error[E0412]: cannot find type `ServerCertVerified` in module `rustls::client`
12.27    --> /root/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rust-s3-0.35.1/src/request/tokio_backend.rs:74:33
12.27     |
12.27  74 |     ) -> Result<rustls::client::ServerCertVerified, rustls::Error> {
12.27     |                                 ^^^^^^^^^^^^^^^^^^ not found in `rustls::client`
12.27     |
12.27 note: found an item that was configured out
12.27    --> /root/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustls-0.21.12/src/lib.rs:436:65
12.27     |
12.27 433 |     #[cfg(feature = "dangerous_configuration")]
12.27     |           ----------------------------------- the item is gated behind the `dangerous_configuration` feature
12.27 ...
12.27 436 |         CertificateTransparencyPolicy, HandshakeSignatureValid, ServerCertVerified,
12.27     |                                                                 ^^^^^^^^^^^^^^^^^^
12.27 
12.30    Compiling tonic v0.12.3
12.43 Some errors have detailed explanations: E0405, E0412, E0433.
12.43 For more information about an error, try `rustc --explain E0405`.
12.44 error: could not compile `rust-s3` (lib) due to 3 previous errors
12.44 warning: build failed, waiting for other jobs to finish...
------
Dockerfile.fdb:40
--------------------
  38 |     COPY resources/ resources/
  39 |     COPY tests/ tests/
  40 | >>> RUN cargo build --manifest-path=crates/main/Cargo.toml --no-default-features --features "foundationdb redis s3" --release
  41 |     
  42 |     FROM debian:trixie-slim AS runtime
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c cargo build --manifest-path=crates/main/Cargo.toml --no-default-features --features \"foundationdb redis s3\" --release" did not complete successfully: exit code: 101

I have tried modifying the regular Dockerfile with what I think is needed to get foundationdb support along with s3, but I have been constantly bumping into the above error when I try. (there is also one separate issue in the Dockerfile but I can put in a PR for that - ie - s/libclang-16-dev/libclang-dev/). After a bunch of rabbit trailing I was wondering if this is related to an issue that might be fixed in rust-s3 v0.36.0-alpha.2

How can we reproduce the problem?

I can reproduce the problem by doing the following steps:

Run docker build -t stalwart-fdb:v0.14.0 -f resources/docker/Dockerfile.fdb . with what is in the main branch, or v0.14.0 with #2303 included

Version

v0.14.x

What database are you using?

FoundationDB

What blob storage are you using?

S3-compatible

Where is your directory located?

Internal

What operating system are you using?

Linux

Relevant log output

Code of Conduct

• I agree to follow this project's Code of Conduct

[mdecimus]

I've just tested compiling Stalwart with those flags and there were no issues. I've moved this to a discussion since the Dockerfile.fdb is provided as an example and not actively maintained.
Could you contribute a fix for it? You can check at the CI jobs for an example of how the FDB binaries are built from a Docker image.

[nissarin]

I'm building my own packages (Gentoo system) and I'm running into the same problem. I started playing with different features and this works on my system: cargo build --no-default-features --features "s3 elastic" but if I remove elastic the build fails.

[stratacast]

I am no rust expert, but I wonder if the elastic package contains tokio deps that get around that compile error. It would be interesting if installing the latest rust-rs would fix this issue.

[stratacast]

I can work on contributing a fix. Is there a reason why foundationdb support isn't built into the standard image?

[stratacast]

Diff for the standard Dockerfile with foundationdb included builds fine

diff --git a/Dockerfile b/Dockerfile
index 0f336f6c..a91c6e95 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,5 +1,5 @@
 # Stalwart Dockerfile
-# Credits: https://github.com/33KK 
+# Credits: https://github.com/33KK
 
 FROM --platform=$BUILDPLATFORM docker.io/lukemathwalker/cargo-chef:latest-rust-slim-trixie AS chef
 WORKDIR /build
@@ -17,14 +17,17 @@ RUN case "${TARGETPLATFORM}" in \
     esac
 RUN export DEBIAN_FRONTEND=noninteractive && \
     apt-get update && \
-    apt-get install -yq --no-install-recommends build-essential libclang-16-dev \
+    apt-get install -yq --no-install-recommends build-essential libclang-dev \
     g++-aarch64-linux-gnu binutils-aarch64-linux-gnu \
-    g++-x86-64-linux-gnu binutils-x86-64-linux-gnu
+    g++-x86-64-linux-gnu binutils-x86-64-linux-gnu \
+    curl adduser
+RUN curl -LO https://github.com/apple/foundationdb/releases/download/7.3.69/foundationdb-clients_7.3.69-1_amd64.deb && \
+    dpkg -i foundationdb-clients_7.3.69-1_amd64.deb
 RUN rustup target add "$(cat /target.txt)"
 COPY --from=planner /recipe.json /recipe.json
-RUN RUSTFLAGS="$(cat /flags.txt)" cargo chef cook --target "$(cat /target.txt)" --release --no-default-features --features "sqlite postgres mysql rocks elastic s3 redis azure nats enterprise" --recipe-path /recipe.json
+RUN RUSTFLAGS="$(cat /flags.txt)" cargo chef cook --target "$(cat /target.txt)" --release --no-default-features --features "foundationdb sqlite postgres mysql rocks elastic s3 redis azure nats enterprise" --recipe-path /recipe.json
 COPY . .
-RUN RUSTFLAGS="$(cat /flags.txt)" cargo build --target "$(cat /target.txt)" --release -p stalwart --no-default-features --features "sqlite postgres mysql rocks elastic s3 redis azure nats enterprise"
+RUN RUSTFLAGS="$(cat /flags.txt)" cargo build --target "$(cat /target.txt)" --release -p stalwart --no-default-features --features "foundationdb sqlite postgres mysql rocks elastic s3 redis azure nats enterprise"
 RUN RUSTFLAGS="$(cat /flags.txt)" cargo build --target "$(cat /target.txt)" --release -p stalwart-cli
 RUN mv "/build/target/$(cat /target.txt)/release" "/output"
 
@@ -32,7 +35,9 @@ FROM docker.io/debian:trixie-slim
 WORKDIR /opt/stalwart
 RUN export DEBIAN_FRONTEND=noninteractive && \
     apt-get update && \
-    apt-get install -yq --no-install-recommends ca-certificates
+    apt-get install -yq --no-install-recommends ca-certificates curl adduser
+RUN curl -LO https://github.com/apple/foundationdb/releases/download/7.3.69/foundationdb-clients_7.3.69-1_amd64.deb && \
+    dpkg -i foundationdb-clients_7.3.69-1_amd64.deb
 COPY --from=builder /output/stalwart /usr/local/bin
 COPY --from=builder /output/stalwart-cli /usr/local/bin
 COPY ./resources/docker/entrypoint.sh /usr/local/bin/entrypoint.sh

[feld]

Reporting the same build issue on FreeBSD. If you add Elastic it doesn't fail building at the rust-s3 step