Clippy fixes

Author: mdecimus

src/common/base32.rs

@@ -40,7 +40,7 @@ impl Base32Writer {
 
     pub fn with_capacity(capacity: usize) -> Self {
         Base32Writer {
-            result: String::with_capacity((capacity + 3) / 4 * 5),
+            result: String::with_capacity(capacity.div_ceil(4) * 5),
             last_byte: 0,
             pos: 0,
         }

src/report/arf/generate.rs

@@ -101,7 +101,7 @@ impl<'x> Feedback<'x> {
     ) -> io::Result<String> {
         let mut buf = Vec::new();
         self.write_rfc5322(from, to, subject, &mut buf)?;
-        String::from_utf8(buf).map_err(|err| io::Error::new(io::ErrorKind::Other, err))
+        String::from_utf8(buf).map_err(io::Error::other)
     }
 
     pub fn to_arf(&self) -> String {

src/report/dmarc/generate.rs

@@ -85,7 +85,7 @@ impl Report {
     ) -> io::Result<String> {
         let mut buf = Vec::new();
         self.write_rfc5322(submitter, from, to, &mut buf)?;
-        String::from_utf8(buf).map_err(|err| io::Error::new(io::ErrorKind::Other, err))
+        String::from_utf8(buf).map_err(io::Error::other)
     }
 
     pub fn to_xml(&self) -> String {

src/report/tlsrpt/generate.rs

@@ -98,7 +98,7 @@ impl TlsReport {
     ) -> io::Result<String> {
         let mut buf = Vec::new();
         self.write_rfc5322(report_domain, submitter, from, to, &mut buf)?;
-        String::from_utf8(buf).map_err(|err| io::Error::new(io::ErrorKind::Other, err))
+        String::from_utf8(buf).map_err(io::Error::other)
     }
 
     pub fn to_json(&self) -> String {

src/spf/verify.rs

@@ -407,7 +407,7 @@ impl MessageAuthenticator {
         }
 
         // Evaluate explain
-        if let (Some(macro_string), Some(SpfResult::Fail { .. })) = (&spf_record.exp, &result) {
+        if let (Some(macro_string), Some(SpfResult::Fail)) = (&spf_record.exp, &result) {
             if let Ok(macro_string) = self
                 .txt_lookup::<Macro>(
                     macro_string.eval(&vars, &domain, true).to_string(),