Skip to content

Commit 0553bf4

Browse files
committed
Replace special string "<none>" with empty string for "storageclass" dimension.
Returning empty string instead of special string "<none>" for "storageclass" dimensions of "kube_persistentvolumeclaim_info" metric.
1 parent 2c3ea01 commit 0553bf4

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

docs/persistentvolumeclaim-metrics.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@
1313

1414
Note:
1515

16-
- A special `<none>` string will be used if PVC has no storage class.
16+
- An empty string will be used if PVC has no storage class.

internal/store/persistentvolumeclaim.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,6 @@ func getPersistentVolumeClaimClass(claim *v1.PersistentVolumeClaim) string {
270270
return *claim.Spec.StorageClassName
271271
}
272272

273-
// Special non-empty string to indicate absence of storage class.
274-
return "<none>"
273+
// An empty string indicate absence of storage class.
274+
return ""
275275
}

internal/store/persistentvolumeclaim_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ func TestPersistentVolumeClaimStore(t *testing.T) {
257257
# TYPE kube_persistentvolumeclaim_status_phase gauge
258258
# TYPE kube_persistentvolumeclaim_status_condition gauge
259259
kube_persistentvolumeclaim_created{namespace="",persistentvolumeclaim="mongo-data"} 1.5e+09
260-
kube_persistentvolumeclaim_info{namespace="",persistentvolumeclaim="mongo-data",storageclass="<none>",volumename=""} 1
260+
kube_persistentvolumeclaim_info{namespace="",persistentvolumeclaim="mongo-data",storageclass="",volumename=""} 1
261261
kube_persistentvolumeclaim_status_phase{namespace="",persistentvolumeclaim="mongo-data",phase="Bound"} 0
262262
kube_persistentvolumeclaim_status_phase{namespace="",persistentvolumeclaim="mongo-data",phase="Lost"} 1
263263
kube_persistentvolumeclaim_status_phase{namespace="",persistentvolumeclaim="mongo-data",phase="Pending"} 0

0 commit comments

Comments
 (0)