Skip to content

Commit c785811

Browse files
authored
Merge pull request #77 from stackhpc/feat/vllm-cpu-image-build
Fix vLLM CPU image build workflow
2 parents 99031e1 + 7fa85b1 commit c785811

File tree

1 file changed

+30
-26
lines changed

1 file changed

+30
-26
lines changed

.github/workflows/build-push-vllm-cpu.yml

Lines changed: 30 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ on:
1414
required: true
1515

1616
jobs:
17-
build_push_image:
17+
build_push_x86_image:
1818
name: Build and push image
1919
runs-on: ubuntu-latest
2020
permissions:
@@ -36,32 +36,36 @@ jobs:
3636
username: ${{ github.actor }}
3737
password: ${{ secrets.GITHUB_TOKEN }}
3838

39-
- name: Calculate metadata for image
40-
id: image-meta
41-
uses: docker/metadata-action@v5
39+
- name: Build and push image
40+
run: |
41+
IMAGE=ghcr.io/stackhpc/vllm-cpu:${{ inputs.vllm_ref }}
42+
docker build -f Dockerfile.cpu -t $IMAGE --shm-size=4g .
43+
docker push $IMAGE
44+
45+
build_push_arm64_image:
46+
name: Build and push image
47+
runs-on: ubuntu-24.04-arm
48+
permissions:
49+
contents: read
50+
id-token: write # needed for signing the images with GitHub OIDC Token
51+
packages: write # required for pushing container images
52+
security-events: write # required for pushing SARIF files
53+
steps:
54+
- name: Check out the vLLM repository
55+
uses: actions/checkout@v4
4256
with:
43-
images: ghcr.io/stackhpc/vllm-cpu
44-
# Produce the branch name or tag and the SHA as tags
45-
tags: |
46-
type=raw,value=${{ inputs.vllm_ref }}
57+
repository: vllm-project/vllm
58+
ref: ${{ inputs.vllm_ref }}
4759

48-
- name: Build and push image x86 image
49-
uses: azimuth-cloud/github-actions/docker-multiarch-build-push@master
60+
- name: Login to GitHub Container Registry
61+
uses: docker/login-action@v3
5062
with:
51-
cache-key: vllm-cpu
52-
file: Dockerfile.cpu
53-
platforms: linux/amd64
54-
push: true
55-
tags: ${{ steps.image-meta.outputs.tags }}
56-
labels: ${{ steps.image-meta.outputs.labels }}
63+
registry: ghcr.io
64+
username: ${{ github.actor }}
65+
password: ${{ secrets.GITHUB_TOKEN }}
5766

58-
# TODO: Test whether this works
59-
# - name: Build and push Arm image
60-
# uses: azimuth-cloud/github-actions/docker-multiarch-build-push@master
61-
# with:
62-
# cache-key: vllm-cpu
63-
# file: Dockerfile.cpu
64-
# platforms: linux/arm64
65-
# push: true
66-
# tags: ${{ steps.image-meta.outputs.tags }}
67-
# labels: ${{ steps.image-meta.outputs.labels }}
67+
- name: Build and push image
68+
run: |
69+
IMAGE=ghcr.io/stackhpc/vllm-cpu:${{ inputs.vllm_ref }}-arm64
70+
docker build -f Dockerfile.arm -t $IMAGE --shm-size=4g .
71+
docker push $IMAGE

0 commit comments

Comments
 (0)