Merge pull request #343 from stac-utils/pv/guard-for-thumbnail

Phil Varner · web-flow · commit 5568738acfac · 2022-12-21T14:54:13.000-05:00
add guard around item roles not existing in thumbnail check
diff --git a/src/lib/api.js b/src/lib/api.js
@@ -875,7 +875,10 @@ const getItemThumbnail = async function (collectionId, itemId, backend) {
     return new Error('Item not found')
   }
 
-  const thumbnailAsset = Object.values(item.assets || []).find((x) => x.roles.includes('thumbnail'))
+  const thumbnailAsset = Object.values(item.assets || []).find(
+    (x) => x.roles && x.roles.includes('thumbnail')
+  )
+
   if (!thumbnailAsset) {
     return new Error('Thumbnail not found')
   }

Original file line number	Diff line number	Diff line change
`@@ -875,7 +875,10 @@ const getItemThumbnail = async function (collectionId, itemId, backend) {`
`875`	`875`	`return new Error('Item not found')`
`876`	`876`	`}`
`877`	`877`
`878`		`- const thumbnailAsset = Object.values(item.assets \|\| []).find((x) => x.roles.includes('thumbnail'))`
	`878`	`+ const thumbnailAsset = Object.values(item.assets \|\| []).find(`
	`879`	`+ (x) => x.roles && x.roles.includes('thumbnail')`
	`880`	`+ )`
	`881`	`+`
`879`	`882`	`if (!thumbnailAsset) {`
`880`	`883`	`return new Error('Thumbnail not found')`
`881`	`884`	`}`