make default False

Author: mishaschwartz

pystac_client/client.py

@@ -443,14 +443,14 @@ def get_collections(self) -> Iterator[Collection]:
                 call_modifier(self.modifier, collection)
                 yield collection
 
-    def get_items(self, *ids: str, recursive: bool = True) -> Iterator["Item_Type"]:
+    def get_items(self, *ids: str, recursive: bool = False) -> Iterator["Item_Type"]:
         """Return all items of this catalog.
 
         Args:
             ids: Zero or more item ids to find.
             recursive : If True, search this catalog and all children for the
                 item; otherwise, only search the items of this catalog. Defaults
-                to True.
+                to False.
 
         Return:
             Iterator[Item]: Iterator of items whose parent is this
@@ -481,7 +481,7 @@ def get_all_items(self) -> Iterator["Item_Type"]:
                 catalogs or collections connected to this catalog through
                 child links.
         """
-        yield from self.get_items()
+        yield from self.get_items(recursive=True)
 
     def search(
         self,

tests/test_client.py

@@ -789,7 +789,7 @@ def test_recursion_on_fallback() -> None:
     path = "https://raw.githubusercontent.com/stac-utils/pystac/v1.9.0/docs/example-catalog/catalog.json"
     catalog = Client.from_file(path)
     with pytest.warns(FallbackToPystac):
-        next(catalog.get_items())
+        next(catalog.get_items(recursive=True))
 
 
 @pytest.mark.vcr