changes

Author: Pete Sramek

PolylineAlgorithm.slnx

@@ -3,7 +3,6 @@
     <Project Path="benchmarks/PolylineAlgorithm.Benchmarks/PolylineAlgorithm.Benchmarks.csproj" />
     <Project Path="benchmarks/PolylineAlgorithm.Comparison.Benchmarks/PolylineAlgorithm.Comparison.Benchmarks.csproj" />
   </Folder>
-  <Folder Name="/samples/" />
   <Folder Name="/src/">
     <Project Path="src/PolylineAlgorithm/PolylineAlgorithm.csproj" />
   </Folder>

src/PolylineAlgorithm/Coordinate.cs

@@ -17,9 +17,6 @@ namespace PolylineAlgorithm;
 [DebuggerDisplay("{ToString()}")]
 [StructLayout(LayoutKind.Sequential, Pack = 8, Size = 16)]
 public readonly struct Coordinate : IEquatable<Coordinate> {
-    public static readonly Coordinate Default;
-    internal static long Size { get; } = Marshal.SizeOf<Coordinate>();
-
     /// <summary>
     /// Initializes a new instance of the <see cref="Coordinate"/> struct with default values for <see cref="Latitude"/> and <see cref="Longitude"/>.
     /// </summary>
@@ -60,9 +57,7 @@ public bool IsDefault()
     /// Determines whether the coordinate is valid by checking if both <see cref="Latitude"/> and <see cref="Longitude"/> are within their respective valid ranges.
     /// </summary>
     /// <returns><see langword="true"/> if the coordinate is valid; otherwise, <see langword="false"/>.</returns>
-    public bool IsValid()
-        => ICoordinateValidator.Default.Latitude.IsInRange(Latitude)
-        && ICoordinateValidator.Default.Longitude.IsInRange(Longitude);
+    public bool IsValid() => ICoordinateValidator.Default.IsValid(this);
 
     #region Overrides
 

src/PolylineAlgorithm/Validation/CoordinateRange.cs renamed to src/PolylineAlgorithm/Internal/CoordinateRange.cs

@@ -3,7 +3,7 @@
 // Licensed under the MIT License. See LICENSE file in the project root for full license information.
 //
 
-namespace PolylineAlgorithm.Validation;
+namespace PolylineAlgorithm.Internal;
 
 using PolylineAlgorithm.Properties;
 using System;
@@ -17,7 +17,7 @@ namespace PolylineAlgorithm.Validation;
 /// </summary>
 [DebuggerDisplay("{ToString()}")]
 [StructLayout(LayoutKind.Sequential, Pack = 8, Size = 16)]
-public readonly struct CoordinateRange : IEquatable<CoordinateRange> {
+internal readonly struct CoordinateRange : IEquatable<CoordinateRange> {
     /// <summary>
     /// Initializes a new instance of the <see cref="CoordinateRange"/> struct with <see cref="Min"/>
     /// set to <see cref="double.MinValue"/> and <see cref="Max"/> set to <see cref="double.MaxValue"/>.

src/PolylineAlgorithm/Validation/CoordinateValidator.cs renamed to src/PolylineAlgorithm/Internal/CoordinateValidator.cs

@@ -3,13 +3,16 @@
 // Licensed under the MIT License. See LICENSE file in the project root for full license information.
 //
 
-namespace PolylineAlgorithm.Validation;
+namespace PolylineAlgorithm.Internal;
+
+using PolylineAlgorithm;
+using PolylineAlgorithm.Validation;
 
 /// <summary>
 /// Provides functionality to validate geographic coordinates based on specified latitude and longitude ranges.
 /// Implements the <see cref="ICoordinateValidator"/> interface.
 /// </summary>
-public sealed class CoordinateValidator : ICoordinateValidator {
+internal sealed class CoordinateValidator : ICoordinateValidator {
     /// <summary>
     /// Initializes a new instance of the <see cref="CoordinateValidator"/> class with the specified latitude and longitude ranges.
     /// </summary>
@@ -38,9 +41,7 @@ public CoordinateValidator(CoordinateRange latitudeRange, CoordinateRange longit
     /// <see langword="true"/> if the <paramref name="coordinate"/> is within the valid latitude and longitude ranges;
     /// otherwise, <see langword="false"/>.
     /// </returns>
-    public bool IsValid(Coordinate coordinate) {
-        return
-            Latitude.IsInRange(coordinate.Latitude)
+    public bool IsValid(Coordinate coordinate) =>
+        Latitude.IsInRange(coordinate.Latitude)
             && Longitude.IsInRange(coordinate.Longitude);
-    }
 }

src/PolylineAlgorithm/Internal/CoordinateVariance.cs

@@ -10,7 +10,7 @@
 /// This struct is used to calculate and store the differences between coordinate values.
 /// </summary>
 [DebuggerDisplay($"{{{nameof(ToString)}(),nq}}")]
-[StructLayout(LayoutKind.Auto)]
+[StructLayout(LayoutKind.Sequential, Pack = 4, Size = 8)]
 internal struct CoordinateVariance {
     private (int Latitude, int Longitude) _current = (0, 0);
 

src/PolylineAlgorithm/Internal/Defaults.cs

@@ -4,8 +4,6 @@
 //
 
 namespace PolylineAlgorithm.Internal;
-
-using PolylineAlgorithm.Validation;
 using System.Diagnostics.CodeAnalysis;
 
 /// <summary>
@@ -53,7 +51,7 @@ public static class Polyline {
         /// An array of delimiters used in the polyline encoding process.
         /// Each delimiter is derived by adding the ASCII value of the question mark ('?') to a range of integers.
         /// </summary>
-        public static readonly byte[] Delimiters = [.. Enumerable.Range(0, 32).Select(n => (byte)(n + Defaults.Algorithm.QuestionMark))];
+        public static readonly byte[] Delimiters = [.. Enumerable.Range(0, 32).Select(n => (byte)(n + Algorithm.QuestionMark))];
 
         /// <summary>
         /// The minimum length of an encoded coordinate in the polyline format.

src/PolylineAlgorithm/Polyline.cs

@@ -89,7 +89,7 @@ public override string ToString() {
             return Value.FirstSpan.ToString();
         }
 
-        var sb = Value.Length <= int.MaxValue ? new StringBuilder((int)(Value.Length)) : new StringBuilder();
+        var sb = Value.Length <= int.MaxValue ? new StringBuilder((int)Value.Length) : new StringBuilder();
         var enumerator = Value.GetEnumerator();
 
         while (true) {

src/PolylineAlgorithm/PolylineEncoder.cs

@@ -7,6 +7,7 @@ namespace PolylineAlgorithm;
 
 using PolylineAlgorithm.Abstraction;
 using PolylineAlgorithm.Internal;
+using PolylineAlgorithm.Properties;
 using System;
 using System.Collections.Generic;
 using System.Runtime.CompilerServices;
@@ -42,7 +43,7 @@ public Polyline Encode(IEnumerable<Coordinate> coordinates) {
         int count = GetCount(coordinates);
 
         if (count == 0) {
-            throw new ArgumentException(nameof(coordinates));
+            throw new ArgumentException(ExceptionMessageResource.ArgumentCannotBeEmptyEnumerationMessage, nameof(coordinates));
         }
 
         CoordinateVariance variance = new();
@@ -82,7 +83,7 @@ public Polyline Encode(IEnumerable<Coordinate> coordinates) {
         }
 
         builder
-            .Append(buffer[..position].ToString().AsMemory());
+            .Append(buffer[..position].ToArray().AsMemory());
 
         return builder.Build();
 

src/PolylineAlgorithm/Validation/ICoordinateValidator.cs

@@ -12,15 +12,15 @@ namespace PolylineAlgorithm.Validation;
 /// against predefined valid ranges.
 /// </summary>
 public interface ICoordinateValidator {
-    /// <summary>
-    /// Gets the range within which the latitude value is considered valid.
-    /// </summary>
-    CoordinateRange Latitude { get; }
+    ///// <summary>
+    ///// Gets the range within which the latitude value is considered valid.
+    ///// </summary>
+    //CoordinateRange Latitude { get; }
 
-    /// <summary>
-    /// Gets the range within which the longitude value is considered valid.
-    /// </summary>
-    CoordinateRange Longitude { get; }
+    ///// <summary>
+    ///// Gets the range within which the longitude value is considered valid.
+    ///// </summary>
+    //CoordinateRange Longitude { get; }
 
     /// <summary>
     /// Determines whether the specified coordinate is valid based on the latitude and longitude ranges.
@@ -32,8 +32,10 @@ public interface ICoordinateValidator {
     /// </returns>
     bool IsValid(Coordinate coordinate);
 
+    static void SetDefault(ICoordinateValidator validator) => Default = validator ?? throw new ArgumentNullException(nameof(validator));
+
     /// <summary>
     /// Gets the default coordinate validator instance.
     /// </summary>
-    internal static ICoordinateValidator Default { get; } = new CoordinateValidator(Defaults.Coordinate.Range.Latitude, Defaults.Coordinate.Range.Longitude);
+    internal static ICoordinateValidator Default { get; private set; } = new CoordinateValidator(Defaults.Coordinate.Range.Latitude, Defaults.Coordinate.Range.Longitude);
 }

tests/PolylineAlgorithm.Tests/Validation/CoordinateRangeTest.cs

@@ -5,7 +5,7 @@
 
 namespace PolylineAlgorithm.Tests.Validation;
 
-using PolylineAlgorithm.Validation;
+using PolylineAlgorithm.Internal;
 
 /// <summary>
 /// Tests for the <see cref="CoordinateRange"/> type.

tests/PolylineAlgorithm.Tests/Validation/CoordinateValidatorTest.cs

@@ -5,7 +5,7 @@
 
 namespace PolylineAlgorithm.Tests.Validation;
 
-using PolylineAlgorithm.Validation;
+using PolylineAlgorithm.Internal;
 
 /// <summary>
 /// Tests for the <see cref="CoordinateValidator"/> type.