Support SELECT * in MySQL (#529)

* Add MySQL support for select star

* Remove trailing semicolon

Author: kyleconroy

internal/compiler/go_type.go

@@ -33,6 +33,23 @@ func (r *Result) goInnerType(col *Column, settings config.CombinedSettings) stri
 		}
 	}
 
+	// TODO: Extend the engine interface to handle types
+	switch settings.Package.Engine {
+	case config.EngineMySQL, config.EngineXDolphin:
+		return r.mysqlType(col, settings)
+	case config.EnginePostgreSQL:
+		return r.postgresType(col, settings)
+	case config.EngineXLemon:
+		return r.postgresType(col, settings)
+	default:
+		return "interface{}"
+	}
+}
+
+func (r *Result) postgresType(col *Column, settings config.CombinedSettings) string {
+	columnType := col.DataType
+	notNull := col.NotNull || col.IsArray
+
 	switch columnType {
 	case "serial", "pg_catalog.serial4":
 		if notNull {
@@ -186,3 +203,65 @@ func (r *Result) goInnerType(col *Column, settings config.CombinedSettings) stri
 		return "interface{}"
 	}
 }
+
+func (r *Result) mysqlType(col *Column, settings config.CombinedSettings) string {
+	columnType := col.DataType
+	notNull := col.NotNull || col.IsArray
+
+	switch columnType {
+
+	case "varchar", "text", "char", "tinytext", "mediumtext", "longtext":
+		if notNull {
+			return "string"
+		}
+		return "sql.NullString"
+
+	case "int", "integer", "smallint", "mediumint", "year":
+		if notNull {
+			return "int32"
+		}
+		return "sql.NullInt32"
+
+	case "bigint":
+		if notNull {
+			return "int64"
+		}
+		return "sql.NullInt64"
+
+	case "blob", "binary", "varbinary", "tinyblob", "mediumblob", "longblob":
+		return "[]byte"
+
+	case "double", "double precision", "real":
+		if notNull {
+			return "float64"
+		}
+		return "sql.NullFloat64"
+
+	case "decimal", "dec", "fixed":
+		if notNull {
+			return "string"
+		}
+		return "sql.NullString"
+
+	case "enum":
+		// TODO: Proper Enum support
+		return "string"
+
+	case "date", "timestamp", "datetime", "time":
+		if notNull {
+			return "time.Time"
+		}
+		return "sql.NullTime"
+
+	case "boolean", "bool", "tinyint":
+		if notNull {
+			return "bool"
+		}
+		return "sql.NullBool"
+
+	default:
+		log.Printf("unknown MySQL type: %s\n", columnType)
+		return "interface{}"
+
+	}
+}

internal/dolphin/convert.go

@@ -62,6 +62,15 @@ func convertCreateTableStmt(n *pcast.CreateTableStmt) ast.Node {
 		IfNotExists: n.IfNotExists,
 	}
 	for _, def := range n.Cols {
+		var vals *ast.List
+		if len(def.Tp.Elems) > 0 {
+			vals = &ast.List{}
+			for i := range def.Tp.Elems {
+				vals.Items = append(vals.Items, &ast.String{
+					Str: def.Tp.Elems[i],
+				})
+			}
+		}
 		create.Cols = append(create.Cols, &ast.ColumnDef{
 			Colname:   def.Name.String(),
 			TypeName:  &ast.TypeName{Name: types.TypeStr(def.Tp.Tp)},
@@ -79,30 +88,64 @@ func convertDropTableStmt(n *pcast.DropTableStmt) ast.Node {
 	return drop
 }
 
-func convertSelectStmt(n *pcast.SelectStmt) ast.Node {
+func convertFieldList(n *pcast.FieldList) *ast.List {
+	fields := make([]ast.Node, len(n.Fields))
+	for i := range n.Fields {
+		fields[i] = convertSelectField(n.Fields[i])
+	}
+	return &ast.List{Items: fields}
+}
+
+func convertSelectField(n *pcast.SelectField) *pg.ResTarget {
+	var val ast.Node
+	if n.WildCard != nil {
+		val = convertWildCardField(n.WildCard)
+	} else {
+		val = convert(n.Expr)
+	}
+	var name *string
+	if n.AsName.O != "" {
+		name = &n.AsName.O
+	}
+	return &pg.ResTarget{
+		// TODO: Populate Indirection field
+		Name:     name,
+		Val:      val,
+		Location: n.Offset,
+	}
+}
+
+func convertSelectStmt(n *pcast.SelectStmt) *pg.SelectStmt {
+	return &pg.SelectStmt{
+		TargetList: convertFieldList(n.Fields),
+		FromClause: convertTableRefsClause(n.From),
+	}
+}
+
+func convertTableRefsClause(n *pcast.TableRefsClause) *ast.List {
 	var tables []ast.Node
-	visit(n.From, func(n pcast.Node) {
+	visit(n, func(n pcast.Node) {
 		name, ok := n.(*pcast.TableName)
 		if !ok {
 			return
 		}
-		tables = append(tables, parseTableName(name))
-	})
-	var cols []ast.Node
-	visit(n.Fields, func(n pcast.Node) {
-		col, ok := n.(*pcast.ColumnName)
-		if !ok {
-			return
-		}
-		cols = append(cols, &ast.ResTarget{
-			Val: &ast.ColumnRef{
-				Name: col.Name.String(),
-			},
+		schema := name.Schema.String()
+		rel := name.Name.String()
+		tables = append(tables, &pg.RangeVar{
+			Schemaname: &schema,
+			Relname:    &rel,
 		})
 	})
-	return &pg.SelectStmt{
-		FromClause: &ast.List{Items: tables},
-		TargetList: &ast.List{Items: cols},
+	return &ast.List{Items: tables}
+}
+
+func convertWildCardField(n *pcast.WildCardField) *pg.ColumnRef {
+	return &pg.ColumnRef{
+		Fields: &ast.List{
+			Items: []ast.Node{
+				&pg.A_Star{},
+			},
+		},
 	}
 }
 

internal/dolphin/parse.go

@@ -73,7 +73,7 @@ func (p *Parser) Parse(r io.Reader) ([]ast.Statement, error) {
 			Raw: &ast.RawStmt{
 				Stmt:         out,
 				StmtLocation: loc,
-				StmtLen:      len(text),
+				StmtLen:      len(text) - 1, // Subtract one to remove semicolon
 			},
 		})
 	}

internal/endtoend/testdata/dolphin_select_star/endtoend.json

@@ -0,0 +1,3 @@
+{
+  "experimental_parser_only": true
+}

internal/endtoend/testdata/dolphin_select_star/go/db.go

@@ -0,0 +1,2 @@
+/* name: GetAll :many */
+SELECT * FROM users;

internal/endtoend/testdata/dolphin_select_star/go/models.go

@@ -0,0 +1,6 @@
+CREATE TABLE users (
+    id integer NOT NULL AUTO_INCREMENT PRIMARY KEY,
+    first_name varchar(255) NOT NULL,
+    last_name varchar(255),
+    age integer NOT NULL
+) ENGINE=InnoDB;

internal/endtoend/testdata/dolphin_select_star/go/query.sql.go

@@ -0,0 +1,13 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "name": "querytest",
+      "path": "go",
+      "schema": "schema.sql",
+      "queries": "query.sql",
+      "engine": "_dolphin",
+      "emit_json_tags": true
+    }
+  ]
+}