Skip to content

Commit 8644195

Browse files
earthboundkidearthboundkid
authored
Remove direct use of pgtype.Array with pgx/v5 (#2090)
* goType: don't use pgtype.Array * pgx/v5: update tests
1 parent a230810 commit 8644195

File tree

12 files changed

+20
-38
lines changed

12 files changed

+20
-38
lines changed

‎internal/codegen/golang/go_type.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,6 @@ func goType(req *plugin.CodeGenRequest, col *plugin.Column) string {
3838
}
3939
typ := goInnerType(req, col)
4040
if col.IsArray {
41-
if parseDriver(req.Settings.Go.SqlPackage) == SQLDriverPGXV5 {
42-
return "pgtype.Array[" + typ + "]"
43-
}
4441
return "[]" + typ
4542
}
4643
return typ

‎internal/endtoend/testdata/any/pgx/v5/go/query.sql.go

Lines changed: 1 addition & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/endtoend/testdata/array_text/pgx/v5/go/models.go

Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/endtoend/testdata/array_text/pgx/v5/go/query.sql.go

Lines changed: 3 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/endtoend/testdata/array_text_join/pgx/v5/go/models.go

Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/endtoend/testdata/array_text_join/pgx/v5/go/query.sql.go

Lines changed: 3 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/endtoend/testdata/ddl_alter_table_alter_type/postgresql/pgx/v5/go/models.go

Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/endtoend/testdata/exec_imports/pgx/v5/go/models.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/endtoend/testdata/overrides/postgresql/pgx/v5/go/models.go

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/endtoend/testdata/select_text_array/pgx/v5/go/query.sql.go

Lines changed: 3 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)